Re: [PATCH 1/2] big key: get rid of stack array allocation

2018-03-20 Thread Tycho Andersen
Hi Eric, On Wed, Mar 14, 2018 at 06:51:39PM -0700, Eric Biggers wrote: > On Mon, Mar 12, 2018 at 10:29:06PM -0600, Tycho Andersen wrote: > > We're interested in getting rid of all of the stack allocated arrays in the > > kernel [1]. This patch removes one in keys by switching to malloc/free. > > N

Re: [PATCH 1/2] big key: get rid of stack array allocation

2018-03-14 Thread Eric Biggers
On Mon, Mar 12, 2018 at 10:29:06PM -0600, Tycho Andersen wrote: > We're interested in getting rid of all of the stack allocated arrays in the > kernel [1]. This patch removes one in keys by switching to malloc/free. > Note that we use kzalloc, to avoid leaking the nonce. I'm not sure this is > real

[PATCH 1/2] big key: get rid of stack array allocation

2018-03-12 Thread Tycho Andersen
We're interested in getting rid of all of the stack allocated arrays in the kernel [1]. This patch removes one in keys by switching to malloc/free. Note that we use kzalloc, to avoid leaking the nonce. I'm not sure this is really necessary, but extra paranoia seems prudent. Manually tested using t