Re: [PATCH 1/2] audit: print error message when fail to create audit socket

2014-01-07 Thread Richard Guy Briggs
On 14/01/08, Gao feng wrote: > On 01/08/2014 08:53 AM, Andrew Morton wrote: > > On Tue, 17 Dec 2013 11:10:41 +0800 Gao feng wrote: > > > >> print the error message and then return -ENOMEM. > >> > >> ... > >> > >> --- a/kernel/audit.c > >> +++ b/kernel/audit.c > >> @@ -1083,12 +1083,11 @@ static i

Re: [PATCH 1/2] audit: print error message when fail to create audit socket

2014-01-07 Thread Gao feng
On 01/08/2014 08:53 AM, Andrew Morton wrote: > On Tue, 17 Dec 2013 11:10:41 +0800 Gao feng wrote: > >> print the error message and then return -ENOMEM. >> >> ... >> >> --- a/kernel/audit.c >> +++ b/kernel/audit.c >> @@ -1083,12 +1083,11 @@ static int __net_init audit_net_init(struct net *net) >>

Re: [PATCH 1/2] audit: print error message when fail to create audit socket

2014-01-07 Thread Andrew Morton
On Tue, 17 Dec 2013 11:10:41 +0800 Gao feng wrote: > print the error message and then return -ENOMEM. > > ... > > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1083,12 +1083,11 @@ static int __net_init audit_net_init(struct net *net) > pr_info("audit: initializing netlink socket in nam

Re: [PATCH 1/2] audit: print error message when fail to create audit socket

2013-12-19 Thread Richard Guy Briggs
On 13/12/17, Eric Paris wrote: > On Tue, 2013-12-17 at 11:10 +0800, Gao feng wrote: > > print the error message and then return -ENOMEM. > > > > Signed-off-by: Gao feng > > Haha. If it's NULL return. No no, if it's REALLY null audit_panic(). Wow, who committed *that* crap!?! :P Thanks for t

Re: [PATCH 1/2] audit: print error message when fail to create audit socket

2013-12-17 Thread Eric Paris
On Tue, 2013-12-17 at 11:10 +0800, Gao feng wrote: > print the error message and then return -ENOMEM. > > Signed-off-by: Gao feng Haha. If it's NULL return. No no, if it's REALLY null audit_panic(). Acked-by: Eric Paris > --- > kernel/audit.c | 9 - > 1 file changed, 4 insertions(+)

[PATCH 1/2] audit: print error message when fail to create audit socket

2013-12-16 Thread Gao feng
print the error message and then return -ENOMEM. Signed-off-by: Gao feng --- kernel/audit.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 2a0ed0b..041b951 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -1083,12 +1083,11 @@