Re: [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse

2020-07-23 Thread Felipe Balbi
Greg Kroah-Hartman writes: > This file has a HUGE debugging sysfs file that spews out a lot of > information all at once, which violates the one-value-per-file rule for > sysfs. If this is really needed, it should go into debugfs, but given > the age of this driver, I strongly doubt anyone is us

RE: [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse

2020-07-02 Thread Ran Wang
Hi, On Thursday, July 2, 2020 5:07 PM, wrote: > > > > This file has a HUGE debugging sysfs file that spews out a lot of > > information all at once, which violates the one-value-per-file rule > > for sysfs. If this is really needed, it should go into debugfs, but > > given the age of this driver,

RE: [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse

2020-07-02 Thread Peter Chen
> > This file has a HUGE debugging sysfs file that spews out a lot of information > all at > once, which violates the one-value-per-file rule for sysfs. If this is > really needed, it > should go into debugfs, but given the age of this driver, I strongly doubt > anyone is > using it anymore.

[PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse

2020-07-02 Thread Greg Kroah-Hartman
This file has a HUGE debugging sysfs file that spews out a lot of information all at once, which violates the one-value-per-file rule for sysfs. If this is really needed, it should go into debugfs, but given the age of this driver, I strongly doubt anyone is using it anymore. So just remove the f