Re: [PATCH 1/2] PWM: let of_xlate handlers check args count

2014-01-23 Thread Sascha Hauer
On Fri, Jan 24, 2014 at 06:42:54AM +0100, Lothar Waßmann wrote: > Hi, > > > Okay, this works, but there's a problem with pwm-leds. > > > > When the duty cycle is set to zero (when you set the brightness to zero) > > pwm-leds decides to disable the PWM after configuring it. This causes > > the PW

Re: [PATCH 1/2] PWM: let of_xlate handlers check args count

2014-01-23 Thread Lothar Waßmann
Hi, Russell King - ARM Linux wrote: > On Thu, Jan 23, 2014 at 04:53:50PM +, Russell King - ARM Linux wrote: > > On Thu, Jan 23, 2014 at 12:04:44PM +0100, Sascha Hauer wrote: > > > On Thu, Jan 23, 2014 at 11:56:32AM +0100, Lothar Waßmann wrote: > > > > Hi, > > > > > > > > Sascha Hauer wrote: >

Re: [PATCH 1/2] PWM: let of_xlate handlers check args count

2014-01-23 Thread Russell King - ARM Linux
On Thu, Jan 23, 2014 at 04:53:50PM +, Russell King - ARM Linux wrote: > On Thu, Jan 23, 2014 at 12:04:44PM +0100, Sascha Hauer wrote: > > On Thu, Jan 23, 2014 at 11:56:32AM +0100, Lothar Waßmann wrote: > > > Hi, > > > > > > Sascha Hauer wrote: > > > > of_pwm_n_cells for the of_xlate handler is

Re: [PATCH 1/2] PWM: let of_xlate handlers check args count

2014-01-23 Thread Russell King - ARM Linux
On Thu, Jan 23, 2014 at 12:04:44PM +0100, Sascha Hauer wrote: > On Thu, Jan 23, 2014 at 11:56:32AM +0100, Lothar Waßmann wrote: > > Hi, > > > > Sascha Hauer wrote: > > > of_pwm_n_cells for the of_xlate handler is stored in struct pwm_chip, > > > but it is only ever used by the of_xlate handler its

Re: [PATCH 1/2] PWM: let of_xlate handlers check args count

2014-01-23 Thread Sascha Hauer
On Thu, Jan 23, 2014 at 11:56:32AM +0100, Lothar Waßmann wrote: > Hi, > > Sascha Hauer wrote: > > of_pwm_n_cells for the of_xlate handler is stored in struct pwm_chip, > > but it is only ever used by the of_xlate handler itsel. Remove > > of_pwm_n_cells from struct pwm_chip and let the handler do

Re: [PATCH 1/2] PWM: let of_xlate handlers check args count

2014-01-23 Thread Lothar Waßmann
Hi, Sascha Hauer wrote: > of_pwm_n_cells for the of_xlate handler is stored in struct pwm_chip, > but it is only ever used by the of_xlate handler itsel. Remove > of_pwm_n_cells from struct pwm_chip and let the handler do the argument > count checking to simplify the code. > This still does not m

[PATCH 1/2] PWM: let of_xlate handlers check args count

2014-01-23 Thread Sascha Hauer
of_pwm_n_cells for the of_xlate handler is stored in struct pwm_chip, but it is only ever used by the of_xlate handler itsel. Remove of_pwm_n_cells from struct pwm_chip and let the handler do the argument count checking to simplify the code. Signed-off-by: Sascha Hauer --- drivers/pwm/core.c