Re: [PATCH 1/2] PCI: iproc: fix 32-bit build

2016-11-23 Thread Bjorn Helgaas
On Tue, Nov 22, 2016 at 03:17:51PM +0100, Arnd Bergmann wrote: > The newly added code to setup the inbound ranges causes a link error > on 32-bit machines from a 32-bit division: > > drivers/pci/host/pcie-iproc.o: In function `iproc_pcie_setup_ib': > pcie-iproc.c:(.text.iproc_pcie_setup_ib+0x14c):

Re: [PATCH 1/2] PCI: iproc: fix 32-bit build

2016-11-22 Thread Ray Jui
On 11/22/2016 1:13 PM, Arnd Bergmann wrote: > On Tuesday, November 22, 2016 9:42:05 AM CET Ray Jui wrote: >> >> Hmmm, somehow we've never seen this link error for the ARM32 based >> platforms that we build for. Does it behave differently between >> different versions of compilers? >> >> Neverthel

Re: [PATCH 1/2] PCI: iproc: fix 32-bit build

2016-11-22 Thread Arnd Bergmann
On Tuesday, November 22, 2016 9:42:05 AM CET Ray Jui wrote: > > Hmmm, somehow we've never seen this link error for the ARM32 based > platforms that we build for. Does it behave differently between > different versions of compilers? > > Nevertheless, this is a good change to take, thanks! I looke

Re: [PATCH 1/2] PCI: iproc: fix 32-bit build

2016-11-22 Thread Ray Jui
On 11/22/2016 6:17 AM, Arnd Bergmann wrote: > The newly added code to setup the inbound ranges causes a link error > on 32-bit machines from a 32-bit division: > > drivers/pci/host/pcie-iproc.o: In function `iproc_pcie_setup_ib': > pcie-iproc.c:(.text.iproc_pcie_setup_ib+0x14c): undefined refere

[PATCH 1/2] PCI: iproc: fix 32-bit build

2016-11-22 Thread Arnd Bergmann
The newly added code to setup the inbound ranges causes a link error on 32-bit machines from a 32-bit division: drivers/pci/host/pcie-iproc.o: In function `iproc_pcie_setup_ib': pcie-iproc.c:(.text.iproc_pcie_setup_ib+0x14c): undefined reference to `__aeabi_uldivmod' As both sides of the divisio