Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Bjorn Helgaas
On Sat, Sep 08, 2012 at 11:40:52AM -0700, Yinghai Lu wrote: > On Sat, Sep 8, 2012 at 8:34 AM, Feng Tang wrote: > >> This makes lspci work again on my side. The caveat is, kzalloc() will > >> zero out all data while the new local variable leaves some data > >> uninitialized. > > > > Yes, thanks for

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Yinghai Lu
On Sat, Sep 8, 2012 at 8:34 AM, Feng Tang wrote: >> This makes lspci work again on my side. The caveat is, kzalloc() will >> zero out all data while the new local variable leaves some data >> uninitialized. > > Yes, thanks for the quick root cause and fix to the bug in my code. Can you resubmit y

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Feng Tang
On Sat, 8 Sep 2012 21:42:20 +0800 Fengguang Wu wrote: > On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > > > > with this one in pci/next pci config in /sys are not created. > > > > > > 10:~ # lspci -tv > > > pcilib: Cannot open /sys/bus/pci/devices/:00:03.0/config > > > lspci: U

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Yinghai Lu
On Sat, Sep 8, 2012 at 6:42 AM, Fengguang Wu wrote: > On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > >> > with this one in pci/next pci config in /sys are not created. >> > >> > 10:~ # lspci -tv >> > pcilib: Cannot open /sys/bus/pci/devices/:00:03.0/config >> > lspci: Unable to

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Fengguang Wu
On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > > with this one in pci/next pci config in /sys are not created. > > > > 10:~ # lspci -tv > > pcilib: Cannot open /sys/bus/pci/devices/:00:03.0/config > > lspci: Unable to read the standard configuration space header of > > device 00

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-07 Thread Greg Kroah-Hartman
On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > Greg, > > Any reason for using kmalloc instead of local variable during your > rewriting pci search code? > > commit 95247b57ed844511a212265b45cf9a919753aea1 > Author: Greg Kroah-Hartman > Date: Wed Feb 13 11:03:58 2008 -0800 Serio

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-07 Thread Yinghai Lu
On Fri, Sep 7, 2012 at 6:00 PM, Yinghai Lu wrote: > On Thu, Aug 23, 2012 at 12:45 AM, Feng Tang wrote: >> From 57a28ee5e7662ca28ba4c793aa037d64bd082dee Mon Sep 17 00:00:00 2001 >> From: Feng Tang >> Date: Wed, 22 Aug 2012 15:41:51 +0800 >> Subject: [PATCH 1/

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-07 Thread Yinghai Lu
On Thu, Aug 23, 2012 at 12:45 AM, Feng Tang wrote: > From 57a28ee5e7662ca28ba4c793aa037d64bd082dee Mon Sep 17 00:00:00 2001 > From: Feng Tang > Date: Wed, 22 Aug 2012 15:41:51 +0800 > Subject: [PATCH 1/2] PCI: Use local parameter pci_device_id for > pci_get_subsys/class() &

[PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-08-23 Thread Feng Tang
>From 57a28ee5e7662ca28ba4c793aa037d64bd082dee Mon Sep 17 00:00:00 2001 From: Feng Tang Date: Wed, 22 Aug 2012 15:41:51 +0800 Subject: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class() This fixes a kernel warning https://lkml.org/lkml/2012/7/31/682 pci_get_sub