Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-08 Thread Masahiro Yamada
On Thu, Mar 4, 2021 at 8:07 AM Fangrui Song wrote: > > > On 2021-03-03, Masahiro Yamada wrote: > >Hi. > > > >On Wed, Mar 3, 2021 at 6:44 AM Fangrui Song wrote: > >> > >> Reviewed-by: Fangrui Song > >> > >> Thanks for the clean-up! > >> --gcc-toolchain= is an obsscure way searching for GCC instal

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-04 Thread Fāng-ruì Sòng
On Wed, Mar 3, 2021 at 3:07 PM Fangrui Song wrote: > > > On 2021-03-03, Masahiro Yamada wrote: > >Hi. > > > >On Wed, Mar 3, 2021 at 6:44 AM Fangrui Song wrote: > >> > >> Reviewed-by: Fangrui Song > >> > >> Thanks for the clean-up! > >> --gcc-toolchain= is an obsscure way searching for GCC instal

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-03 Thread Fangrui Song
On 2021-03-03, Masahiro Yamada wrote: Hi. On Wed, Mar 3, 2021 at 6:44 AM Fangrui Song wrote: Reviewed-by: Fangrui Song Thanks for the clean-up! --gcc-toolchain= is an obsscure way searching for GCC installation prefixes (--prefix). The logic is complex and different for different distrib

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-03 Thread Sedat Dilek
On Wed, Mar 3, 2021 at 4:25 AM Sedat Dilek wrote: > > On Tue, Mar 2, 2021 at 10:07 PM Nathan Chancellor wrote: > > > > This is not necessary anymore now that we specify '--prefix=', which > > tells clang exactly where to find the GNU cross tools. This has been > > verified with self compiled LLVM

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-03 Thread Masahiro Yamada
Hi. On Wed, Mar 3, 2021 at 6:44 AM Fangrui Song wrote: > > Reviewed-by: Fangrui Song > > Thanks for the clean-up! > --gcc-toolchain= is an obsscure way searching for GCC installation prefixes > (--prefix). > The logic is complex and different for different distributions/architectures. > > If we

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-03 Thread Sedat Dilek
On Tue, Mar 2, 2021 at 10:07 PM Nathan Chancellor wrote: > > This is not necessary anymore now that we specify '--prefix=', which > tells clang exactly where to find the GNU cross tools. This has been > verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a > distribution version of

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-02 Thread Nick Desaulniers
On Tue, Mar 2, 2021 at 1:07 PM Nathan Chancellor wrote: > > This is not necessary anymore now that we specify '--prefix=', which > tells clang exactly where to find the GNU cross tools. This has been > verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a > distribution version of L

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-02 Thread Fangrui Song
Reviewed-by: Fangrui Song Thanks for the clean-up! --gcc-toolchain= is an obsscure way searching for GCC installation prefixes (--prefix). The logic is complex and different for different distributions/architectures. If we specify --prefix= (-B) explicitly, --gcc-toolchain is not needed. On 2

[PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-02 Thread Nathan Chancellor
This is not necessary anymore now that we specify '--prefix=', which tells clang exactly where to find the GNU cross tools. This has been verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a distribution version of LLVM 11.1.0 without binutils in the LLVM toolchain locations. Signe