Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
2018-05-13 17:09 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> 2018-05-13 16:28 GMT+08:00 Liran Alon : >> > >> > - kernel...@gmail.com wrote: >> > >> >> 2018-05-13 15:53 GMT+08:00 Liran Alon : >> >> > >> >> > - kernel...@gmail.com wrote: >> >> > >> >> >> From: Wanpeng Li

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > 2018-05-13 16:28 GMT+08:00 Liran Alon : > > > > - kernel...@gmail.com wrote: > > > >> 2018-05-13 15:53 GMT+08:00 Liran Alon : > >> > > >> > - kernel...@gmail.com wrote: > >> > > >> >> From: Wanpeng Li > >> >> > >> >> MSB of CR3 is a reserved bit if the

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
2018-05-13 16:28 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> 2018-05-13 15:53 GMT+08:00 Liran Alon : >> > >> > - kernel...@gmail.com wrote: >> > >> >> From: Wanpeng Li >> >> >> >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. >> >> It should be checked w

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > 2018-05-13 15:53 GMT+08:00 Liran Alon : > > > > - kernel...@gmail.com wrote: > > > >> From: Wanpeng Li > >> > >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > >> It should be checked when PCIDE bit is not set, however commit > >> 'd1cd3

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
2018-05-13 15:53 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> From: Wanpeng Li >> >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. >> It should be checked when PCIDE bit is not set, however commit >> 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits ba

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > From: Wanpeng Li > > MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > It should be checked when PCIDE bit is not set, however commit > 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on > its physical address width")' remove

[PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-12 Thread Wanpeng Li
From: Wanpeng Li MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. It should be checked when PCIDE bit is not set, however commit 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on its physical address width")' removes the bit 63 checking unconditionally. This pa