Re: [PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-07-03 Thread Michal Marek
On 3.7.2013 14:57, Michal Marek wrote: > On 3.7.2013 14:37, Daniel Tang wrote: >> Hi, >> >> On 03/07/2013, at 10:28 PM, Michal Marek wrote: >>> >>> >>> What is the type of Elf64_Shdr::sh_offset in OS X's ? In >>> glibc, this is Elf64_Off, which is a typedef name for uint64_t. >> >> Huh, that's wei

Re: [PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-07-03 Thread Michal Marek
On 3.7.2013 14:37, Daniel Tang wrote: > Hi, > > On 03/07/2013, at 10:28 PM, Michal Marek wrote: >> >> >> What is the type of Elf64_Shdr::sh_offset in OS X's ? In >> glibc, this is Elf64_Off, which is a typedef name for uint64_t. > > Huh, that's weird. Elf64_Off is defined as unsigned long in m

Re: [PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-07-03 Thread Daniel Tang
Hi, On 03/07/2013, at 10:28 PM, Michal Marek wrote: > > > What is the type of Elf64_Shdr::sh_offset in OS X's ? In glibc, > this is Elf64_Off, which is a typedef name for uint64_t. Huh, that's weird. Elf64_Off is defined as unsigned long in my elf.h which isn't 64 bit on x86_64 pretty sure.

Re: [PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-07-03 Thread Michal Marek
On 3.7.2013 14:12, Daniel Tang wrote: >> On 3.7.2013 14:06, Michal Marek wrote: >>> On 9.6.2013 04:33, Daniel Tang wrote: The pointer passed to the _r() macro does not always match the type of the function that it is aliasing and raises several of the following warnings at compile ti

Re: [PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-07-03 Thread Daniel Tang
Hi, On 03/07/2013, at 10:07 PM, Michal Marek wrote: > On 3.7.2013 14:06, Michal Marek wrote: >> Added David Daney to CC. > > Second attempt, sorry. > > >> On 9.6.2013 04:33, Daniel Tang wrote: >>> The pointer passed to the _r() macro does not always match the type >>> of the function that it

Re: [PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-07-03 Thread Michal Marek
On 3.7.2013 14:06, Michal Marek wrote: > Added David Daney to CC. Second attempt, sorry. > On 9.6.2013 04:33, Daniel Tang wrote: >> The pointer passed to the _r() macro does not always match the type >> of the function that it is aliasing and raises several of the following >> warnings at compil

Re: [PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-07-03 Thread Michal Marek
Added David Daney to CC. On 9.6.2013 04:33, Daniel Tang wrote: > The pointer passed to the _r() macro does not always match the type > of the function that it is aliasing and raises several of the following > warnings at compile time: > > warning: passing argument 1 of ‘r8’ from incompatible poin

[PATCH 1/2] Fix a build warning in scripts/sortextable.h

2013-06-08 Thread Daniel Tang
The pointer passed to the _r() macro does not always match the type of the function that it is aliasing and raises several of the following warnings at compile time: warning: passing argument 1 of ‘r8’ from incompatible pointer type Fixed by casting the pointers to (void *) so they work with both