Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

2012-11-27 Thread Mark Brown
On Mon, Nov 26, 2012 at 09:55:33PM -0800, Peter Korsgaard wrote: > > "Mark" == Mark Brown writes: > Mark> Since the driver is happy to continue without the pins why is it > Mark> bothering requesting them in the first place? In other words, this > Mark> should be a hard error. > Sorry, I

Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

2012-11-26 Thread Peter Korsgaard
> "Mark" == Mark Brown writes: Hi, Mark> On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote: >> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); >> + if (IS_ERR(pinctrl)) >> + dev_warn(&pdev->dev, >> + "pins are not configured from t

Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

2012-11-26 Thread Mark Brown
On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote: > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > + if (IS_ERR(pinctrl)) > + dev_warn(&pdev->dev, > + "pins are not configured from the driver\n"); Since the driver is happy to con

[PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

2012-11-22 Thread Hebbar, Gururaja
From: "Hebbar, Gururaja" Signed-off-by: Hebbar, Gururaja --- :100644 100644 5715595... 76c05d9... M sound/soc/davinci/davinci-mcasp.c sound/soc/davinci/davinci-mcasp.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-m