Re: [PATCH 1/2] ARM: ux500: Move struct

2015-01-24 Thread Arnd Bergmann
On Saturday 24 January 2015 18:33:00 Rickard Strandqvist wrote: > 2015-01-22 8:44 GMT+01:00 Lee Jones : > > > > Are you sure a struct is required at all now? It only contains a > > single bool after all. > > > Hi Lee > > Okay, I will gladly remove ab8500_ext_regulator_cfg completely. > And I wi

Re: [PATCH 1/2] ARM: ux500: Move struct

2015-01-24 Thread Rickard Strandqvist
2015-01-22 8:44 GMT+01:00 Lee Jones : > > Are you sure a struct is required at all now? It only contains a > single bool after all. Hi Lee Okay, I will gladly remove ab8500_ext_regulator_cfg completely. And I will try to update the comments, but since I'm not so familiar with what this code was

Re: [PATCH 1/2] ARM: ux500: Move struct

2015-01-21 Thread Lee Jones
The subject line is not a good one. Please elaborate. > Move struct ab8500_ext_regulator_cfg to the only file that is now used in. Attention to detail --^ > Signed-off-by: Rickard Strandqvist > --- > drivers/regulator/ab8500-ext.c |6 ++ > include/linux/regulator

[PATCH 1/2] ARM: ux500: Move struct

2015-01-21 Thread Rickard Strandqvist
Move struct ab8500_ext_regulator_cfg to the only file that is now used in. Signed-off-by: Rickard Strandqvist --- drivers/regulator/ab8500-ext.c |6 ++ include/linux/regulator/ab8500.h |5 - 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/ab850