Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

2018-06-15 Thread Fabio Estevam
On Thu, Jun 14, 2018 at 7:17 AM, Leonard Crestez wrote: > Should I also assign a label, like "isl29023: light-sensor@44"? I > couldn't find any recommendation on this. > > There are no immediate uses for a label but this practice is very > common. Having labels allows creating minor board variant

Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

2018-06-14 Thread Leonard Crestez
On Thu, 2018-06-07 at 14:07 -0300, Fabio Estevam wrote: > Hi Leonard, > > On Thu, Jun 7, 2018 at 2:00 PM, Leonard Crestez > wrote: > > > + > > + isl29023@44 { > > According to Devicetree Specification v0.2 document: > > "The name of a node should be somewhat generic, ref

Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

2018-06-07 Thread Fabio Estevam
Hi Leonard, On Thu, Jun 7, 2018 at 2:00 PM, Leonard Crestez wrote: > + > + isl29023@44 { According to Devicetree Specification v0.2 document: "The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model." So

[PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

2018-06-07 Thread Leonard Crestez
The following sensors are on I2C3 on the baseboard: * isil,isl29023 light sensor * fsl,mag3110 magnetometer * fsl,mma8451 accelerometer Added under i2cmux/i2c@1 because they're not otherwise accessible. These are all supported by iio with following configs: * CONFIG_SENSORS_ISL29018 * CONFIG_MAG3