Re: [PATCH 1/2] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Vitaly Bordug
On Mon, 7 May 2007 08:56:09 -0500 Olof Johansson wrote: > Hi, > > Some minor nitpicks below. Overall it looks good. > > > -Olof > > On Sun, May 06, 2007 at 05:26:33AM +0400, Vitaly Bordug wrote: > > @@ -322,6 +334,70 @@ void init_smc_ioports(struct > > fs_uart_platform_info *data) } > > } > >

Re: [PATCH 1/2] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-07 Thread Olof Johansson
Hi, Some minor nitpicks below. Overall it looks good. -Olof On Sun, May 06, 2007 at 05:26:33AM +0400, Vitaly Bordug wrote: > @@ -322,6 +334,70 @@ void init_smc_ioports(struct fs_uart_platform_info *data) > } > } > > +#ifdef CONFIG_PCMCIA_M8XX > +static void pcmcia_hw_setup(int slot, in

[PATCH 1/2] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-05 Thread Vitaly Bordug
Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as of_device, so only arch/powerpc stuff is capable to use it, which now implies only mpc885ads reference board. To cope with the code that should be hooked inside driver, but is really board specific (like set_voltage), global