Re: [PATCH 1/11] USB: kl5kusb105: Remove useless return variables

2014-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2014 01:21 AM, Peter Senna Tschudin wrote: This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. The patch does more than just that, it also removes co

Re: [PATCH 1/11] USB: kl5kusb105: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
On Sat, May 31, 2014 at 6:17 PM, Sergei Shtylyov wrote: > Hello. > > > On 05/31/2014 05:14 PM, Peter Senna Tschudin wrote: > >> This patch remove variables that are initialized with a constant, >> are never updated, and are only used as parameter of return. >> Return the constant instead of using

Re: [PATCH 1/11] USB: kl5kusb105: Remove useless return variables

2014-05-31 Thread Sergei Shtylyov
Hello. On 05/31/2014 05:14 PM, Peter Senna Tschudin wrote: This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. The patch does more than just that, it also removes comm

Re: [PATCH 1/11] USB: kl5kusb105: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
On Sat, May 31, 2014 at 11:58 AM, Johan Hovold wrote: > On Sat, May 31, 2014 at 10:14:01AM -0300, Peter Senna Tschudin wrote: >> This patch remove variables that are initialized with a constant, >> are never updated, and are only used as parameter of return. >> Return the constant instead of using

Re: [PATCH 1/11] USB: kl5kusb105: Remove useless return variables

2014-05-31 Thread Johan Hovold
On Sat, May 31, 2014 at 10:14:01AM -0300, Peter Senna Tschudin wrote: > This patch remove variables that are initialized with a constant, > are never updated, and are only used as parameter of return. > Return the constant instead of using a variable. > > Verified by compilation only. > > The coc

[PATCH 1/11] USB: kl5kusb105: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identif