Re: [PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Thierry Reding
On Thu, Mar 07, 2013 at 01:16:08PM -0800, Andrew Chew wrote: > The backlight enable regulator is specified in the device tree node for > backlight. > > Signed-off-by: Andrew Chew This looks good in general. I'd like to see Alex' comment addressed and perhaps the commit message shouldn't be devic

Re: [PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Alex Courbot
On 03/08/2013 06:16 AM, Andrew Chew wrote: The backlight enable regulator is specified in the device tree node for backlight. Signed-off-by: Andrew Chew --- Renamed en_supply to enable_supply to match the corresponding device tree property. Removed unnecessary check for pb->enable_supply valid

[PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Andrew Chew
The backlight enable regulator is specified in the device tree node for backlight. Signed-off-by: Andrew Chew --- Renamed en_supply to enable_supply to match the corresponding device tree property. Removed unnecessary check for pb->enable_supply validity. This supply is mandatory, and probe wil