Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

2012-07-23 Thread Thadeu Lima de Souza Cascardo
On Mon, Jul 23, 2012 at 03:44:41PM +0200, Miguel Gómez wrote: > El 23/07/12 15:36, Matthew Garrett escribió: > >On Mon, Jul 23, 2012 at 03:33:27PM +0200, Miguel Gómez wrote: > > > >>Names are upper-cased in acpica, so the device is reported as > >>FNBT. But in the driver it's named FnBT, an

Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

2012-07-23 Thread Miguel Gómez
El 23/07/12 15:36, Matthew Garrett escribió: On Mon, Jul 23, 2012 at 03:33:27PM +0200, Miguel Gómez wrote: Names are upper-cased in acpica, so the device is reported as FNBT. But in the driver it's named FnBT, and that's why it doesn't match. So just change the existing entry in the d

Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

2012-07-23 Thread Matthew Garrett
On Mon, Jul 23, 2012 at 03:33:27PM +0200, Miguel Gómez wrote: > Names are upper-cased in acpica, so the device is reported as > FNBT. But in the driver it's named FnBT, and that's why it > doesn't match. So just change the existing entry in the driver to FNBT? -- Matthew Garrett | m

Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

2012-07-23 Thread Miguel Gómez
El 23/07/12 15:28, Matthew Garrett escribió: On Wed, Jul 18, 2012 at 03:53:48PM +0200, Miguel Gómez wrote: 1) reverting the patch in acpica that puts all names in uppercase 2) using a case-insensitive match in acpi bus driver 3) using uppercase name in classmate-laptop driver I think the easi

Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

2012-07-23 Thread Matthew Garrett
On Wed, Jul 18, 2012 at 03:53:48PM +0200, Miguel Gómez wrote: > >1) reverting the patch in acpica that puts all names in uppercase > >2) using a case-insensitive match in acpi bus driver > >3) using uppercase name in classmate-laptop driver > > I think the easiest and less risky way to fix this i

Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

2012-07-18 Thread Miguel Gómez
On Fri, Jun 29, 2012 at 03:39:48PM +0200, Miguel Gómez wrote: Classmate V4 laptop includes a new accelerometer that can't be handled by previous driver. This patch adds a new driver to handle it. Signed-off-by: Miguel Gómez Hi, Miguel. This seems OK to me. Thanks for this work. Do you have t

Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

2012-07-17 Thread Thadeu Lima de Souza Cascardo
On Fri, Jun 29, 2012 at 03:39:48PM +0200, Miguel Gómez wrote: > Classmate V4 laptop includes a new accelerometer that can't be handled by > previous driver. This patch adds a new driver to handle it. > > Signed-off-by: Miguel Gómez Hi, Miguel. This seems OK to me. Thanks for this work. Do you h