Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-08 Thread Michal Kubecek
On Wed, Oct 08, 2014 at 09:10:23AM +, David Laight wrote: > From: Hannes Frederic Sowa > > I think David's concern was whether if 0 == false in all situations. It > > is pretty clear that static memory is initialized to 0. > > I'm not 100% sure about that. > static pointers may be required to

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-08 Thread Hannes Frederic Sowa
On Mi, 2014-10-08 at 09:10 +, David Laight wrote: > From: Hannes Frederic Sowa > > I think David's concern was whether if 0 == false in all situations. It > > is pretty clear that static memory is initialized to 0. > > I'm not 100% sure about that. > static pointers may be required to be initi

RE: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-08 Thread David Laight
From: Hannes Frederic Sowa > I think David's concern was whether if 0 == false in all situations. It > is pretty clear that static memory is initialized to 0. I'm not 100% sure about that. static pointers may be required to be initialised to NULL. If NULL isn't the 'all 0 bit pattern' then the mem

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread Fabian Frederick
> On 07 October 2014 at 22:54 Hannes Frederic Sowa > wrote: > > > On Di, 2014-10-07 at 22:49 +0200, Fabian Frederick wrote: > > > > > On 07 October 2014 at 22:33 Guenter Roeck wrote: > > > > > > > > > On Tue, Oct 07, 2014 at 04:18:32PM -0400, David Miller wrote: > > > > From: Fabian Frederick

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread Hannes Frederic Sowa
On Di, 2014-10-07 at 22:49 +0200, Fabian Frederick wrote: > > > On 07 October 2014 at 22:33 Guenter Roeck wrote: > > > > > > On Tue, Oct 07, 2014 at 04:18:32PM -0400, David Miller wrote: > > > From: Fabian Frederick > > > Date: Tue, 7 Oct 2014 22:16:36 +0200 > > > > > > > static values are auto

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread David Miller
From: Fabian Frederick Date: Tue, 7 Oct 2014 22:49:31 +0200 (CEST) > Maybe comment should have been "static values are automatically initialized to > 0" then ? Yes, that sounds a lot better, please respin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread Fabian Frederick
> On 07 October 2014 at 22:33 Guenter Roeck wrote: > > > On Tue, Oct 07, 2014 at 04:18:32PM -0400, David Miller wrote: > > From: Fabian Frederick > > Date: Tue,  7 Oct 2014 22:16:36 +0200 > > > > > static values are automatically initialized to NULL > > > > > > Signed-off-by: Fabian Frederick

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread Guenter Roeck
On Tue, Oct 07, 2014 at 04:18:32PM -0400, David Miller wrote: > From: Fabian Frederick > Date: Tue, 7 Oct 2014 22:16:36 +0200 > > > static values are automatically initialized to NULL > > > > Signed-off-by: Fabian Frederick > > Isn't there some implementation room given to compilers > as to t

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread Hannes Frederic Sowa
On Di, 2014-10-07 at 16:18 -0400, David Miller wrote: > From: Fabian Frederick > Date: Tue, 7 Oct 2014 22:16:36 +0200 > > > static values are automatically initialized to NULL > > > > Signed-off-by: Fabian Frederick > > Isn't there some implementation room given to compilers > as to the repre

Re: [PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread David Miller
From: Fabian Frederick Date: Tue, 7 Oct 2014 22:16:36 +0200 > static values are automatically initialized to NULL > > Signed-off-by: Fabian Frederick Isn't there some implementation room given to compilers as to the representation of true and false? -- To unsubscribe from this list: send the

[PATCH 1/1 net-next] af_unix: remove NULL assignment on static

2014-10-07 Thread Fabian Frederick
static values are automatically initialized to NULL Signed-off-by: Fabian Frederick --- net/unix/garbage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/unix/garbage.c b/net/unix/garbage.c index 9bc73f8..99f7012 100644 --- a/net/unix/garbage.c +++ b/net/unix/garbage.c @