Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-30 Thread Christoph Hellwig
On Thu, Oct 30, 2014 at 10:21:05AM -0500, Don Brace wrote: > I can add this patch to my current set of patches for 3.19 or ack this now, > What would you prefer? Please queue it up, I'm much more interested in reducing the massive backlog of real hpsa changes than in litte cleanups at the moment.

Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-30 Thread Don Brace
On 10/29/2014 10:15 AM, Fabian Frederick wrote: Fix -Wunused-but-set-variable warning Signed-off-by: Fabian Frederick --- drivers/scsi/hpsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index cef5d49..34330e1 100644 --- a/

Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-29 Thread Sudip Mukherjee
tober 30, 2014 12:55 AM > > To: Fabian Frederick > > Cc: linux-kernel@vger.kernel.org; Stephen M. Cameron; James E.J. > > Bottomley; iss_storage...@hp.com; linux-s...@vger.kernel.org > > Subject: Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable > > rc > &g

RE: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-29 Thread Elliott, Robert (Server Storage)
s E.J. > Bottomley; iss_storage...@hp.com; linux-s...@vger.kernel.org > Subject: Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable > rc > > On Wed, Oct 29, 2014 at 04:15:04PM +0100, Fabian Frederick wrote: > > Fix -Wunused-but-set-variable warning > > you shou

Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-29 Thread Sudip Mukherjee
On Wed, Oct 29, 2014 at 04:15:04PM +0100, Fabian Frederick wrote: > Fix -Wunused-but-set-variable warning you should also mention why you have left the call to irq_set_affinity_hint(). i am not sure , but it looks like irq_set_affinity_hint() is only checking if the lock is available or not. It is

[PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-29 Thread Fabian Frederick
Fix -Wunused-but-set-variable warning Signed-off-by: Fabian Frederick --- drivers/scsi/hpsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index cef5d49..34330e1 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -66