Re: [PATCH 1/1] workqueue: use type int instead of bool to index array

2017-09-06 Thread Tejun Heo
On Thu, Sep 07, 2017 at 01:07:23AM +0800, zijun_hu wrote: > in this case, i think type int is more suitable than bool in aspects of > extendibility, program custom and consistency. Please stop. -- tejun

Re: [PATCH 1/1] workqueue: use type int instead of bool to index array

2017-09-06 Thread zijun_hu
On 2017/9/7 0:40, Tejun Heo wrote: > On Thu, Sep 07, 2017 at 12:04:59AM +0800, zijun_hu wrote: >> On 2017/9/6 22:33, Tejun Heo wrote: >>> Hello, >>> >>> On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote: From: zijun_hu type bool is used to index three arrays in alloc_and_link

Re: [PATCH 1/1] workqueue: use type int instead of bool to index array

2017-09-06 Thread Tejun Heo
On Thu, Sep 07, 2017 at 12:04:59AM +0800, zijun_hu wrote: > On 2017/9/6 22:33, Tejun Heo wrote: > > Hello, > > > > On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote: > >> From: zijun_hu > >> > >> type bool is used to index three arrays in alloc_and_link_pwqs() > >> it doesn't look like con

Re: [PATCH 1/1] workqueue: use type int instead of bool to index array

2017-09-06 Thread zijun_hu
On 2017/9/6 22:33, Tejun Heo wrote: > Hello, > > On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote: >> From: zijun_hu >> >> type bool is used to index three arrays in alloc_and_link_pwqs() >> it doesn't look like conventional. >> >> it is fixed by using type int to index the relevant array

Re: [PATCH 1/1] workqueue: use type int instead of bool to index array

2017-09-06 Thread Tejun Heo
Hello, On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote: > From: zijun_hu > > type bool is used to index three arrays in alloc_and_link_pwqs() > it doesn't look like conventional. > > it is fixed by using type int to index the relevant arrays. bool is a uint type which can be either 0

[PATCH 1/1] workqueue: use type int instead of bool to index array

2017-09-05 Thread zijun_hu
From: zijun_hu type bool is used to index three arrays in alloc_and_link_pwqs() it doesn't look like conventional. it is fixed by using type int to index the relevant arrays. Signed-off-by: zijun_hu --- kernel/workqueue.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --