Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-05 Thread Lee Jones
On Wed, 04 Sep 2019, Stephen Boyd wrote: > Quoting Lee Jones (2019-09-04 23:42:53) > > > > But if this is the one whack left to get the thing to boot then I think > > > > we should merge it. > > > > > > Agreed. > > > > Thanks Stephen. > > > > Unless you guys scream loudly, I'm going to convert

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Stephen Boyd
Quoting Lee Jones (2019-09-04 23:42:53) > > > But if this is the one whack left to get the thing to boot then I think > > > we should merge it. > > > > Agreed. > > Thanks Stephen. > > Unless you guys scream loudly, I'm going to convert these to Acks. > > If you scream softly, I can convert the

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Lee Jones
On Wed, 04 Sep 2019, Bjorn Andersson wrote: > On Wed 04 Sep 13:01 PDT 2019, Lee Jones wrote: > > > On Wed, 04 Sep 2019, Bjorn Andersson wrote: > > > > > On Wed 04 Sep 01:45 PDT 2019, Lee Jones wrote: > > > > > > > On Tue, 03 Sep 2019, Bjorn Andersson wrote: > > > > > > > > > On Tue 03 Sep 06:5

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Lee Jones
> > But if this is the one whack left to get the thing to boot then I think > > we should merge it. > > Agreed. Thanks Stephen. Unless you guys scream loudly, I'm going to convert these to Acks. If you scream softly, I can convert the to Reviewed-bys. -- Lee Jones [李琼斯] Linaro Services Techni

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Stephen Boyd
Quoting Bjorn Andersson (2019-09-04 11:27:32) > On Wed 04 Sep 01:45 PDT 2019, Lee Jones wrote: > > > On Tue, 03 Sep 2019, Bjorn Andersson wrote: > > > > > On Tue 03 Sep 06:50 PDT 2019, Lee Jones wrote: > > > > > > > When booting with ACPI, the Geni Serial Engine is not set as the I2C/SPI > > > >

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Bjorn Andersson
On Wed 04 Sep 13:01 PDT 2019, Lee Jones wrote: > On Wed, 04 Sep 2019, Bjorn Andersson wrote: > > > On Wed 04 Sep 01:45 PDT 2019, Lee Jones wrote: > > > > > On Tue, 03 Sep 2019, Bjorn Andersson wrote: > > > > > > > On Tue 03 Sep 06:50 PDT 2019, Lee Jones wrote: [..] > > > With this simple parame

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Lee Jones
On Wed, 04 Sep 2019, Bjorn Andersson wrote: > On Wed 04 Sep 01:45 PDT 2019, Lee Jones wrote: > > > On Tue, 03 Sep 2019, Bjorn Andersson wrote: > > > > > On Tue 03 Sep 06:50 PDT 2019, Lee Jones wrote: > > > > > > > When booting with ACPI, the Geni Serial Engine is not set as the I2C/SPI > > > >

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Bjorn Andersson
On Wed 04 Sep 01:45 PDT 2019, Lee Jones wrote: > On Tue, 03 Sep 2019, Bjorn Andersson wrote: > > > On Tue 03 Sep 06:50 PDT 2019, Lee Jones wrote: > > > > > When booting with ACPI, the Geni Serial Engine is not set as the I2C/SPI > > > parent and thus, the wrapper (parent device) is unassigned.

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-04 Thread Lee Jones
On Tue, 03 Sep 2019, Bjorn Andersson wrote: > On Tue 03 Sep 06:50 PDT 2019, Lee Jones wrote: > > > When booting with ACPI, the Geni Serial Engine is not set as the I2C/SPI > > parent and thus, the wrapper (parent device) is unassigned. This causes > > the kernel to crash with a null dereference

Re: [PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-03 Thread Bjorn Andersson
On Tue 03 Sep 06:50 PDT 2019, Lee Jones wrote: > When booting with ACPI, the Geni Serial Engine is not set as the I2C/SPI > parent and thus, the wrapper (parent device) is unassigned. This causes > the kernel to crash with a null dereference error. > Now I see what you did in 8bc529b25354; i.e.

[PATCH 1/1] soc: qcom: geni: Provide parameter error checking

2019-09-03 Thread Lee Jones
When booting with ACPI, the Geni Serial Engine is not set as the I2C/SPI parent and thus, the wrapper (parent device) is unassigned. This causes the kernel to crash with a null dereference error. Fixes: 8bc529b25354 ("soc: qcom: geni: Add support for ACPI") Signed-off-by: Lee Jones --- Since we