Re: [PATCH 1/1] rpmsg: virtio: Make buffer size and number configurable

2023-10-03 Thread Tanmay Shah
On 10/3/23 10:28 AM, Divin Raj wrote: > Hello, > > Thanks for all review comments. > It makes sense to incorporate a variable-length buffer size. However, we > still require an implementation that can successfully achieve this objective. > > We will be investigating this matter and will return w

Re: [PATCH 1/1] rpmsg: virtio: Make buffer size and number configurable

2023-09-28 Thread Tanmay Shah
Hello, Thanks for your patch. Instead of having this in Kconfig, It's better to have buffer size decided dynamically. Probably by resource-table. We still need implementation that achieves that goal. Meanwhile  I think it's best to keep buffer size fixed. Thanks. On 9/28/23 10:38 AM, Divin R

Re: [PATCH 1/1] rpmsg: virtio: Make buffer size and number configurable

2023-09-28 Thread Randy Dunlap
Hi, On 9/28/23 08:38, Divin Raj wrote: > From: Peter Hoyes > > Replace the MAX_RPMSG_BUF_SIZE and MAX_RPMSG_NUM_BUFS #define in > virtio_rpmsg_bus.c with the Kconfig parameters CONFIG_RPMSG_VIRTIO_BUF_SIZE > and CONFIG_RPMSG_VIRTIO_MAX_NUM_BUFS, allowing user-provided customization. > > Making

[PATCH 1/1] rpmsg: virtio: Make buffer size and number configurable

2023-09-28 Thread Divin Raj
From: Peter Hoyes Replace the MAX_RPMSG_BUF_SIZE and MAX_RPMSG_NUM_BUFS #define in virtio_rpmsg_bus.c with the Kconfig parameters CONFIG_RPMSG_VIRTIO_BUF_SIZE and CONFIG_RPMSG_VIRTIO_MAX_NUM_BUFS, allowing user-provided customization. Making both the number of buffers and size configurable facil