Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2015-06-27 Thread Dan Carpenter
On Fri, Jun 26, 2015 at 04:06:55PM -0700, Darren Hart wrote: > Julia, do you have any particular objection to this specific patch? I didn't > see > a reason to prevent it going in. I hate these patches... We're saying "these functions have sanity checks so let's pass nonsense values to them, it'

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2015-06-27 Thread Julia Lawall
On Fri, 26 Jun 2015, Darren Hart wrote: > On Thu, Nov 27, 2014 at 07:13:10PM +0100, Julia Lawall wrote: > > > > > > On Mon, 24 Nov 2014, SF Markus Elfring wrote: > > > > > >> This issue was detected by using the Coccinelle software. > > > > > > > > What script was used ? > > > > > > A semanti

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2015-06-26 Thread Darren Hart
On Thu, Nov 27, 2014 at 07:13:10PM +0100, Julia Lawall wrote: > > > On Mon, 24 Nov 2014, SF Markus Elfring wrote: > > > >> This issue was detected by using the Coccinelle software. > > > > > > What script was used ? > > > > A semantic patch approach which I published on the mailing lists in Marc

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-27 Thread Julia Lawall
On Mon, 24 Nov 2014, SF Markus Elfring wrote: > >> This issue was detected by using the Coccinelle software. > > > > What script was used ? > > A semantic patch approach which I published on the mailing lists in March > is in action on my software development system for a while. > > > > Is it in

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-24 Thread Darren Hart
On Mon, Nov 24, 2014 at 08:40:22PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Nov 2014 20:30:29 +0100 > > The backlight_device_unregister() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > Thi

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-24 Thread SF Markus Elfring
>> This issue was detected by using the Coccinelle software. > > What script was used ? A semantic patch approach which I published on the mailing lists in March is in action on my software development system for a while. > Is it in scripts/coccinelle ? Not yet. I hope that the involved updat

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-24 Thread Anisse Astier
Hi Markus, Le lundi 24 novembre 2014, 20:40:22 SF Markus Elfring a écrit : > From: Markus Elfring > Date: Mon, 24 Nov 2014 20:30:29 +0100 > > The backlight_device_unregister() function tests whether its argument is > NULL and then returns immediately. Thus the test around the call is not > neede

[PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 24 Nov 2014 20:30:29 +0100 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elf