Re: [PATCH 1/1] perf: Add CPU hotplug support for events

2018-02-19 Thread Peter Zijlstra
On Fri, Feb 16, 2018 at 05:48:21PM -0800, Raghavendra Rao Ananta wrote: > I am sure we can fix it, but apart > from the "why we are doing hotplug?" question, was was there specifically > any issue with our patch? Yes, the extra list is crazy. We don't keep events in extra lists when a task isn't c

Re: [PATCH 1/1] perf: Add CPU hotplug support for events

2018-02-16 Thread Raghavendra Rao Ananta
On 02/16/2018 12:39 PM, Peter Zijlstra wrote: On Fri, Feb 16, 2018 at 10:06:29AM -0800, Raghavendra Rao Ananta wrote: No this is absolutely disguisting. You can simply keep the events in the dead CPU's context. It's really not that hard. Keeping the events in the dead CPU's context was also a

Re: [PATCH 1/1] perf: Add CPU hotplug support for events

2018-02-16 Thread Peter Zijlstra
On Fri, Feb 16, 2018 at 10:06:29AM -0800, Raghavendra Rao Ananta wrote: > > No this is absolutely disguisting. You can simply keep the events in the > > dead CPU's context. It's really not that hard. > Keeping the events in the dead CPU's context was also an idea that we had. > However, detaching t

Re: [PATCH 1/1] perf: Add CPU hotplug support for events

2018-02-16 Thread Raghavendra Rao Ananta
On 02/16/2018 12:21 AM, Peter Zijlstra wrote: On Thu, Feb 15, 2018 at 03:01:41PM -0800, Raghavendra Rao Ananta wrote: Perf framework doesn't allow prevserving CPU events across CPU hotplugs. The events are scheduled out as and when the CPU walks offline. Moreover, the framework also doesn't al

Re: [PATCH 1/1] perf: Add CPU hotplug support for events

2018-02-16 Thread Peter Zijlstra
On Thu, Feb 15, 2018 at 03:01:41PM -0800, Raghavendra Rao Ananta wrote: > Perf framework doesn't allow prevserving CPU events across > CPU hotplugs. The events are scheduled out as and when the > CPU walks offline. Moreover, the framework also doesn't > allow the clients to create events on an offl

[PATCH 1/1] perf: Add CPU hotplug support for events

2018-02-15 Thread Raghavendra Rao Ananta
Perf framework doesn't allow prevserving CPU events across CPU hotplugs. The events are scheduled out as and when the CPU walks offline. Moreover, the framework also doesn't allow the clients to create events on an offline CPU. As a result, the clients have to keep on monitoring the CPU state until