Re: [PATCH 1/1] perf/x86/intel: make error messages less confusing

2018-08-22 Thread Eduardo Valentin
Hey, On Tue, Aug 21, 2018 at 04:59:08PM -0700, Andi Kleen wrote: > On Tue, Aug 21, 2018 at 04:05:22PM -0700, Eduardo Valentin wrote: > > On Tue, Aug 21, 2018 at 03:09:37PM -0700, Andi Kleen wrote: > > > On Tue, Aug 21, 2018 at 02:15:28PM -0700, Eduardo Valentin wrote: > > > > On a system with X86_

Re: [PATCH 1/1] perf/x86/intel: make error messages less confusing

2018-08-22 Thread Peter Zijlstra
On Tue, Aug 21, 2018 at 04:05:22PM -0700, Eduardo Valentin wrote: > On Tue, Aug 21, 2018 at 03:09:37PM -0700, Andi Kleen wrote: > > On Tue, Aug 21, 2018 at 02:15:28PM -0700, Eduardo Valentin wrote: > > > [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU > > > driver, software eve

Re: [PATCH 1/1] perf/x86/intel: make error messages less confusing

2018-08-21 Thread Andi Kleen
On Tue, Aug 21, 2018 at 04:05:22PM -0700, Eduardo Valentin wrote: > On Tue, Aug 21, 2018 at 03:09:37PM -0700, Andi Kleen wrote: > > On Tue, Aug 21, 2018 at 02:15:28PM -0700, Eduardo Valentin wrote: > > > On a system with X86_FEATURE_ARCH_PERFMON disabled > > > and with a model not known by family P

Re: [PATCH 1/1] perf/x86/intel: make error messages less confusing

2018-08-21 Thread Eduardo Valentin
On Tue, Aug 21, 2018 at 03:09:37PM -0700, Andi Kleen wrote: > On Tue, Aug 21, 2018 at 02:15:28PM -0700, Eduardo Valentin wrote: > > On a system with X86_FEATURE_ARCH_PERFMON disabled > > and with a model not known by family PMU drivers, > > user gets a kernel message log like the following: > > [ 0

Re: [PATCH 1/1] perf/x86/intel: make error messages less confusing

2018-08-21 Thread Andi Kleen
On Tue, Aug 21, 2018 at 02:15:28PM -0700, Eduardo Valentin wrote: > On a system with X86_FEATURE_ARCH_PERFMON disabled > and with a model not known by family PMU drivers, > user gets a kernel message log like the following: > [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver

[PATCH 1/1] perf/x86/intel: make error messages less confusing

2018-08-21 Thread Eduardo Valentin
On a system with X86_FEATURE_ARCH_PERFMON disabled and with a model not known by family PMU drivers, user gets a kernel message log like the following: [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver, software events only. The "unsupported .. CPU" part may be confusing f