Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

2015-02-20 Thread Ryusuke Konishi
On Fri, 20 Feb 2015 18:00:55 -0800, Andrew Morton wrote: > On Sat, 21 Feb 2015 10:13:28 +0900 (JST) Ryusuke Konishi > wrote: > >> I've got a warning from 0day kernel testing backend: >> >> fs/nilfs2/btree.c: In function 'nilfs_btree_root_broken': >> >> fs/nilfs2/btree.c:394:3: warning: form

Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

2015-02-20 Thread Andrew Morton
On Sat, 21 Feb 2015 10:13:28 +0900 (JST) Ryusuke Konishi wrote: > I've got a warning from 0day kernel testing backend: > > fs/nilfs2/btree.c: In function 'nilfs_btree_root_broken': > >> fs/nilfs2/btree.c:394:3: warning: format '%lu' expects argument of type > >> 'long unsigned int', but ar

Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

2015-02-20 Thread Ryusuke Konishi
On Sat, 21 Feb 2015 09:22:08 +0900 (JST), Ryusuke Konishi wrote: > On Fri, 20 Feb 2015 13:58:42 -0800, Andrew Morton wrote: >> On Fri, 20 Feb 2015 22:46:35 +0900 Ryusuke Konishi >> wrote: >> >>> Each inode of nilfs2 stores a root node of a b-tree, and it turned out >>> to have a memory overrun i

Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

2015-02-20 Thread Ryusuke Konishi
On Fri, 20 Feb 2015 13:58:42 -0800, Andrew Morton wrote: > On Fri, 20 Feb 2015 22:46:35 +0900 Ryusuke Konishi > wrote: > >> Each inode of nilfs2 stores a root node of a b-tree, and it turned out >> to have a memory overrun issue: >> >> Each b-tree node of nilfs2 stores a set of key-value pairs

Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

2015-02-20 Thread Andrew Morton
On Fri, 20 Feb 2015 22:46:35 +0900 Ryusuke Konishi wrote: > Each inode of nilfs2 stores a root node of a b-tree, and it turned out > to have a memory overrun issue: > > Each b-tree node of nilfs2 stores a set of key-value pairs and the > number of them (in "bn_nchildren" member of nilfs_btree_n

[PATCH 1/1] nilfs2: fix potential memory overrun on inode

2015-02-20 Thread Ryusuke Konishi
Each inode of nilfs2 stores a root node of a b-tree, and it turned out to have a memory overrun issue: Each b-tree node of nilfs2 stores a set of key-value pairs and the number of them (in "bn_nchildren" member of nilfs_btree_node struct), as well as a few other "bn_*" members. Since the value of