Re: [PATCH 1/1] net/mlx5: Call pci_disable_sriov() on remove

2020-04-30 Thread Niklas Schnelle
On 4/30/20 9:47 PM, Niklas Schnelle wrote: > > > On 4/30/20 5:58 PM, Saeed Mahameed wrote: >> On Thu, 2020-04-30 at 14:03 +0200, Niklas Schnelle wrote: >>> as described in Documentation/PCI/pci-iov-howto.rst a driver with SR- >>> IOV >>> support should call pci_disable_sriov() in the remove ha

Re: [PATCH 1/1] net/mlx5: Call pci_disable_sriov() on remove

2020-04-30 Thread Niklas Schnelle
On 4/30/20 5:58 PM, Saeed Mahameed wrote: > On Thu, 2020-04-30 at 14:03 +0200, Niklas Schnelle wrote: >> as described in Documentation/PCI/pci-iov-howto.rst a driver with SR- >> IOV >> support should call pci_disable_sriov() in the remove handler. > > Hi Niklas, > > looking at the documentatio

Re: [PATCH 1/1] net/mlx5: Call pci_disable_sriov() on remove

2020-04-30 Thread Saeed Mahameed
On Thu, 2020-04-30 at 14:03 +0200, Niklas Schnelle wrote: > as described in Documentation/PCI/pci-iov-howto.rst a driver with SR- > IOV > support should call pci_disable_sriov() in the remove handler. Hi Niklas, looking at the documentation, it doesn't say "should" it just gives the code as examp

[PATCH 1/1] net/mlx5: Call pci_disable_sriov() on remove

2020-04-30 Thread Niklas Schnelle
as described in Documentation/PCI/pci-iov-howto.rst a driver with SR-IOV support should call pci_disable_sriov() in the remove handler. Otherwise removing a PF (e.g. via pci_stop_and_remove_bus_device()) with attached VFs does not properly shut the VFs down before shutting down the PF. This leads t