Re: [PATCH 1/1] mxser, remove it

2007-12-29 Thread Jiri Slaby
On 12/29/2007 03:23 AM, Alan Cox wrote: >>> +static int mxvar_baud_table[] = { >>> + 0, 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400, >>> + 4800, 9600, 19200, 38400, 57600, 115200, 230400, 460800, 921600 >>> +}; >>> +static unsigned int mxvar_baud_table1[] = { >>> + 0, B50, B75, B11

Re: [PATCH 1/1] mxser, remove it

2007-12-28 Thread Alan Cox
> + if (cmd == MOXA_SET_SPECIAL_BAUD_RATE) { > + int speed; > + > + if (get_user(speed, (int __user *)argp)) > + return -EFAULT; > + if (speed <= 0 || speed > info->max_baud) > + return -EFAULT; -EINVAL > +

Re: [PATCH 1/1] mxser, remove it

2007-12-28 Thread Alan Cox
> > > >+static int mxvar_baud_table[] = { > >+0, 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400, > >+4800, 9600, 19200, 38400, 57600, 115200, 230400, 460800, 921600 > >+}; > >+static unsigned int mxvar_baud_table1[] = { > >+0, B50, B75, B110, B134, B150, B200, B300, B600, B1200

Re: [PATCH 1/1] mxser, remove it

2007-12-28 Thread Jan Engelhardt
On Dec 28 2007 11:09, Jiri Slaby wrote: > >+struct mxser_cardinfo { >+ unsigned int nports; >+ char *name; >+ unsigned int flags; >+}; const char *name. Maybe name could also be put at the front to get closer struct packing on 64-bit? > >+static int mxvar_baud_table[] = { >+

Re: [PATCH 1/1] mxser, remove it

2007-12-27 Thread Jiri Slaby
On 12/27/2007 06:21 PM, Adrian Bunk wrote: > On Thu, Dec 27, 2007 at 06:19:31PM +0300, Michael Tokarev wrote: >> Jiri Slaby wrote: >>> (Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007. >>> Remove it. >>> >>> Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> >>> --- >>> Docum

Re: [PATCH 1/1] mxser, remove it

2007-12-27 Thread Adrian Bunk
On Thu, Dec 27, 2007 at 06:19:31PM +0300, Michael Tokarev wrote: > Jiri Slaby wrote: > > (Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007. > > Remove it. > > > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > > --- > > Documentation/feature-removal-schedule.txt |8

Re: [PATCH 1/1] mxser, remove it

2007-12-27 Thread Michael Tokarev
Jiri Slaby wrote: > (Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007. > Remove it. > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > --- > Documentation/feature-removal-schedule.txt |8 - > drivers/char/Kconfig | 11 - > drivers/char/Makefi