Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Pavel Tatashin
On Thu, Jul 18, 2019 at 12:04 PM Leonardo Bras wrote: > > On Thu, 2019-07-18 at 08:19 -0400, Pavel Tatashin wrote: > > On Wed, Jul 17, 2019 at 10:42 PM Leonardo Bras > > wrote: > > > Adds an option on kernel config to make hot-added memory online in > > > ZONE_MOVABLE by default. > > > > > > Thi

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Pavel Tatashin
> > Just trying to understand, if kernel parameters is the preferable > > method, why do we even have > > > > MEMORY_HOTPLUG_DEFAULT_ONLINE > > I have some opinion on this one TBH. I have even tried to remove it. The > config option has been added to workaround hotplug issues for some > memory ball

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Michal Hocko
On Thu 18-07-19 12:11:25, Pavel Tatashin wrote: > On Thu, Jul 18, 2019 at 11:57 AM Michal Hocko wrote: > > > > On Thu 18-07-19 12:50:29, Leonardo Bras wrote: > > > On Thu, 2019-07-18 at 08:12 +0200, Oscar Salvador wrote: > > > > We do already have "movable_node" boot option, which exactly has that

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Pavel Tatashin
On Thu, Jul 18, 2019 at 11:57 AM Michal Hocko wrote: > > On Thu 18-07-19 12:50:29, Leonardo Bras wrote: > > On Thu, 2019-07-18 at 08:12 +0200, Oscar Salvador wrote: > > > We do already have "movable_node" boot option, which exactly has that > > > effect. > > > Any hotplugged range will be placed i

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Leonardo Bras
On Thu, 2019-07-18 at 08:19 -0400, Pavel Tatashin wrote: > On Wed, Jul 17, 2019 at 10:42 PM Leonardo Bras wrote: > > Adds an option on kernel config to make hot-added memory online in > > ZONE_MOVABLE by default. > > > > This would be great in systems with MEMORY_HOTPLUG_DEFAULT_ONLINE=y by > > a

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Michal Hocko
On Thu 18-07-19 12:50:29, Leonardo Bras wrote: > On Thu, 2019-07-18 at 08:12 +0200, Oscar Salvador wrote: > > We do already have "movable_node" boot option, which exactly has that > > effect. > > Any hotplugged range will be placed in ZONE_MOVABLE. > Oh, I was not aware of it. > > > Why do we need

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Leonardo Bras
On Thu, 2019-07-18 at 08:12 +0200, Oscar Salvador wrote: > We do already have "movable_node" boot option, which exactly has that > effect. > Any hotplugged range will be placed in ZONE_MOVABLE. Oh, I was not aware of it. > Why do we need yet another option to achieve the same? Was not that > enoug

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-18 Thread Pavel Tatashin
On Wed, Jul 17, 2019 at 10:42 PM Leonardo Bras wrote: > > Adds an option on kernel config to make hot-added memory online in > ZONE_MOVABLE by default. > > This would be great in systems with MEMORY_HOTPLUG_DEFAULT_ONLINE=y by > allowing to choose which zone it will be auto-onlined This is a desi

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-17 Thread Mike Rapoport
On Wed, Jul 17, 2019 at 11:41:34PM -0300, Leonardo Bras wrote: > Adds an option on kernel config to make hot-added memory online in > ZONE_MOVABLE by default. > > This would be great in systems with MEMORY_HOTPLUG_DEFAULT_ONLINE=y by > allowing to choose which zone it will be auto-onlined Please

Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-17 Thread Oscar Salvador
On Wed, 2019-07-17 at 23:41 -0300, Leonardo Bras wrote: > Adds an option on kernel config to make hot-added memory online in > ZONE_MOVABLE by default. > > This would be great in systems with MEMORY_HOTPLUG_DEFAULT_ONLINE=y > by > allowing to choose which zone it will be auto-onlined We do alread

[PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE

2019-07-17 Thread Leonardo Bras
Adds an option on kernel config to make hot-added memory online in ZONE_MOVABLE by default. This would be great in systems with MEMORY_HOTPLUG_DEFAULT_ONLINE=y by allowing to choose which zone it will be auto-onlined Signed-off-by: Leonardo Bras --- drivers/base/memory.c | 3 +++ mm/Kconfig