Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-15 Thread Dave Young
On 06/15/16 at 10:40am, Willy Tarreau wrote: > On Wed, Jun 15, 2016 at 04:33:32PM +0800, Dave Young wrote: > > On 06/14/16 at 10:41pm, Willy Tarreau wrote: > > > On Tue, Jun 14, 2016 at 01:19:06PM -0700, Andrew Morton wrote: > > > > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt > > > > w

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-15 Thread Willy Tarreau
On Wed, Jun 15, 2016 at 04:33:32PM +0800, Dave Young wrote: > On 06/14/16 at 10:41pm, Willy Tarreau wrote: > > On Tue, Jun 14, 2016 at 01:19:06PM -0700, Andrew Morton wrote: > > > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt > > > wrote: > > > > > > > An undetected overflow may occur i

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-15 Thread Dave Young
On 06/14/16 at 10:41pm, Willy Tarreau wrote: > On Tue, Jun 14, 2016 at 01:19:06PM -0700, Andrew Morton wrote: > > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt > > wrote: > > > > > An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. > > > > > > ... > > > > > > --- a

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-14 Thread Kees Cook
On Tue, Jun 14, 2016 at 1:19 PM, Andrew Morton wrote: > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt > wrote: > >> An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. >> >> ... >> >> --- a/kernel/sysctl.c >> +++ b/kernel/sysctl.c >> @@ -2313,7 +2313,17 @@ static int

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-14 Thread Willy Tarreau
On Tue, Jun 14, 2016 at 01:19:06PM -0700, Andrew Morton wrote: > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt > wrote: > > > An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. > > > > ... > > > > --- a/kernel/sysctl.c > > +++ b/kernel/sysctl.c > > @@ -2313,7 +2313

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-14 Thread Andrew Morton
On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt wrote: > An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. > > ... > > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2313,7 +2313,17 @@ static int do_proc_dointvec_minmax_conv(bool *negp, > unsigned long *lvalp,

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-14 Thread Kees Cook
On Fri, Jun 10, 2016 at 6:33 PM, Heinrich Schuchardt wrote: > An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. > > Signed-off-by: Heinrich Schuchardt Acked-by: Kees Cook Thanks for the fix! -Kees > --- > kernel/sysctl.c | 12 +++- > 1 file changed, 11 insertio

[PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-10 Thread Heinrich Schuchardt
An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. Signed-off-by: Heinrich Schuchardt --- kernel/sysctl.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 35f0dcb..a9e7be3 100644 --- a/kernel/sysctl.c ++