Re: [PATCH 1/1] file capabilities: get_file_caps cleanups

2007-06-28 Thread Serge E. Hallyn
get 'inside' the 'if (rc) { <-here ... }'. Oops! Good catch, thanks. New patch follows: >From 9e8d4dd0486c85e269a062a4637a8b6296fcb80b Mon Sep 17 00:00:00 2001 From: Serge E. Hallyn <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 19:55:27 -0400 Subject: [PATCH 1/1]

Re: [PATCH 1/1] file capabilities: get_file_caps cleanups

2007-06-28 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Serge E. Hallyn wrote: kfree(dcaps); > Move this two lines down (rc defaults to 0 in goto above): > from here--> +clear_caps: + if (rc) { > to here--> > >> Hmm? But if we succeeded we still want to free dcaps if we >> kmall

Re: [PATCH 1/1] file capabilities: get_file_caps cleanups

2007-06-28 Thread Serge E. Hallyn
CTED]> > > Date: Wed, 27 Jun 2007 19:55:27 -0400 > > Subject: [PATCH 1/1] file capabilities: get_file_caps cleanups > > > > Two cleanups relating to set_file caps. > [...] > > @@ -187,12 +186,21 @@ out: > > dput(dentry); > > if ((void *)dc

Re: [PATCH 1/1] file capabilities: get_file_caps cleanups

2007-06-27 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This contains a typo: Serge E. Hallyn wrote: >>From 588755d9498c87c4e963527ba0f49c11107de354 Mon Sep 17 00:00:00 2001 > From: Serge E. Hallyn <[EMAIL PROTECTED]> > Date: Wed, 27 Jun 2007 19:55:27 -0400 > Subject: [PATCH 1

[PATCH 1/1] file capabilities: get_file_caps cleanups

2007-06-27 Thread Serge E. Hallyn
>From 588755d9498c87c4e963527ba0f49c11107de354 Mon Sep 17 00:00:00 2001 From: Serge E. Hallyn <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 19:55:27 -0400 Subject: [PATCH 1/1] file capabilities: get_file_caps cleanups Two cleanups relating to set_file caps. Rename set_file_caps to get_