Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

2017-03-15 Thread Jiri Slaby
On 03/15/2017, 04:58 PM, Steven Rostedt wrote: > Great, cause I'm currently cleaning up that code too, and this would > cause conflicts ;-) Then I should hide right after I send out v2 of the macros cleanup series in a couple of minutes, right ;)? https://patchwork.kernel.org/patch/9579623/ -- j

Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

2017-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2017 16:49:54 +0100 Jiri Slaby wrote: > On 03/15/2017, 04:40 PM, Steven Rostedt wrote: > >> -#else > >> -# define function_hookmcount > >> -EXPORT_SYMBOL(mcount) > >> -#endif > >> - > >> /* All cases save the original rbp (8 bytes) */ > >> #ifdef CONFIG_FRAME_POINTER > >> #

Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

2017-03-15 Thread Jiri Slaby
On 03/15/2017, 04:40 PM, Steven Rostedt wrote: >> -#else >> -# define function_hook mcount >> -EXPORT_SYMBOL(mcount) >> -#endif >> - >> /* All cases save the original rbp (8 bytes) */ >> #ifdef CONFIG_FRAME_POINTER >> # ifdef CC_USING_FENTRY >> @@ -297,6 +290,7 @@ trace: >> jmp fgraph_

Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

2017-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2017 14:44:36 +0100 Jiri Slaby wrote: > @@ -16,14 +17,6 @@ > > #ifdef CONFIG_FUNCTION_TRACER > > -#ifdef CC_USING_FENTRY > -# define function_hook __fentry__ > -EXPORT_SYMBOL(__fentry__) There's a reason the export symbols are here. > -#else > -# define function_hook

[PATCH 1/1] fentry: x86, cleanup function_hook uses

2017-03-15 Thread Jiri Slaby
Let's define fentry_hook depending on CC_USING_FENTRY and use that macro over the users. This saves some #ifdef's in the assembly and headers. Signed-off-by: Jiri Slaby Cc: Thomas Gleixner Cc: "H. Peter Anvin" Cc: Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar --- arch/x86/incl

Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

2015-10-20 Thread Steven Rostedt
On Tue, 6 Oct 2015 14:40:21 +0200 Jiri Slaby wrote: > Let's define fentry_hook depending on CC_USING_FENTRY and use that > macro all over. This saves some #ifdef's here and there. > > We do not use the old macro function_hook since it is too generic. > Hence we introduce fentry_hook which corre

[PATCH 1/1] fentry: x86, cleanup function_hook uses

2015-10-06 Thread Jiri Slaby
Let's define fentry_hook depending on CC_USING_FENTRY and use that macro all over. This saves some #ifdef's here and there. We do not use the old macro function_hook since it is too generic. Hence we introduce fentry_hook which corresponds to what it is. Signed-off-by: Jiri Slaby Cc: Thomas Glei