Re: [PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-22 Thread Vinod Koul
On Sat, Jul 19, 2014 at 03:21:47AM +0200, Javier Martinez Canillas wrote: > Commit 6079d38 ("dmaengine: pl330: Remove useless xfer_cb indirection") > removed the __callback() function which created an unnecessary level of > indirection to execute the tranfer callback .xfer_cb > > Unfortunately the

Re: [PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-21 Thread Javier Martinez Canillas
On 07/21/2014 10:22 AM, Lars-Peter Clausen wrote: > On 07/20/2014 07:58 PM, Javier Martinez Canillas wrote: >> >> If this should not really happen and this patch is only a workaround since >> the >> bug is elsewhere, please give me some hints and I'll try to fix it properly. >> I'm >> not familia

Re: [PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-21 Thread Lars-Peter Clausen
On 07/20/2014 07:58 PM, Javier Martinez Canillas wrote: Hello Lars-Peter, On 07/20/2014 04:18 PM, Lars-Peter Clausen wrote: On 07/19/2014 03:21 AM, Javier Martinez Canillas wrote: Commit 6079d38 ("dmaengine: pl330: Remove useless xfer_cb indirection") removed the __callback() function which cr

Re: [PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-20 Thread Javier Martinez Canillas
Hello Lars-Peter, On 07/20/2014 04:18 PM, Lars-Peter Clausen wrote: > On 07/19/2014 03:21 AM, Javier Martinez Canillas wrote: >> Commit 6079d38 ("dmaengine: pl330: Remove useless xfer_cb indirection") >> removed the __callback() function which created an unnecessary level of >> indirection to exec

Re: [PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-20 Thread Lars-Peter Clausen
On 07/19/2014 03:21 AM, Javier Martinez Canillas wrote: Commit 6079d38 ("dmaengine: pl330: Remove useless xfer_cb indirection") removed the __callback() function which created an unnecessary level of indirection to execute the tranfer callback .xfer_cb Unfortunately the commit also changed the s

[PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-18 Thread Javier Martinez Canillas
Commit 6079d38 ("dmaengine: pl330: Remove useless xfer_cb indirection") removed the __callback() function which created an unnecessary level of indirection to execute the tranfer callback .xfer_cb Unfortunately the commit also changed the semantics slightly since that function used to check if the