Re: [PATCH 1/1] btrfs: fix improper return value

2016-12-12 Thread David Sterba
On Sun, Dec 04, 2016 at 11:57:07AM -0800, Omar Sandoval wrote: > On Sun, Dec 04, 2016 at 12:51:53PM +0800, Pan Bian wrote: > > In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret > > on errors. However, it directly returns 0. It may be better to return > > ret. This patch also

Re: [PATCH 1/1] btrfs: fix improper return value

2016-12-04 Thread Omar Sandoval
On Sun, Dec 04, 2016 at 12:51:53PM +0800, Pan Bian wrote: > In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret > on errors. However, it directly returns 0. It may be better to return > ret. This patch also removes the warning, because the caller already > prints a warning. >

[PATCH 1/1] btrfs: fix improper return value

2016-12-03 Thread Pan Bian
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret on errors. However, it directly returns 0. It may be better to return ret. This patch also removes the warning, because the caller already prints a warning. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Signed-

Re: [PATCH 1/1] btrfs: fix improper return value

2016-12-03 Thread Omar Sandoval
On Sat, Dec 03, 2016 at 06:55:16PM +0800, Pan Bian wrote: > In function btrfs_uuid_tree_iterate(), errno is assigned to variable > ret on errors. However, it directly returns 0. It may be better to > return ret. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 > > Signed-off-by: P

[PATCH 1/1] btrfs: fix improper return value

2016-12-03 Thread Pan Bian
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret on errors. However, it directly returns 0. It may be better to return ret. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Signed-off-by: Pan Bian --- fs/btrfs/uuid-tree.c | 2 +- 1 file changed, 1 insertion(+