Re: Has slab ctor operation changed? -- was [PATCH 1/1] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-24 Thread Christoph Lameter
On Thu, 20 Feb 2014, David Howells wrote: > Of course, it's possible that the slab allocator no longer works like this... They still work like that (aside from SLOB that calls the ctor on each alloc but that also has never changed). -- To unsubscribe from this list: send the line "unsubscribe li

Re: Has slab ctor operation changed? -- was [PATCH 1/1] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread Fabian Frederick
On Thu, 20 Feb 2014 22:23:15 + David Howells wrote: > Fabian Frederick wrote: > > > afs_vnode is currently cleared with 2 memsets after allocation and > > 1 in constructor (afs_i_init_once). > > -This patch calls zalloc for explicit zero fill. > > Ummm... This patch isn't necessarily

Re: Has slab ctor operation changed? -- was [PATCH 1/1] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread Dave Chinner
On Thu, Feb 20, 2014 at 10:23:15PM +, David Howells wrote: > Fabian Frederick wrote: > > > afs_vnode is currently cleared with 2 memsets after allocation and > > 1 in constructor (afs_i_init_once). > > -This patch calls zalloc for explicit zero fill. > > Ummm... This patch isn't necess

Has slab ctor operation changed? -- was [PATCH 1/1] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread David Howells
Fabian Frederick wrote: > afs_vnode is currently cleared with 2 memsets after allocation and > 1 in constructor (afs_i_init_once). > -This patch calls zalloc for explicit zero fill. Ummm... This patch isn't necessarily correct in the substantiative portions. Since afs_i_init_once() is c

Re: [PATCH 1/1] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread David Howells
Joe Perches wrote: > > - * initialise an inode cache slab element prior to any use > > + * Initialize an inode cache slab element prior to any use > > English spellings don't need to be changed to American. Indeed! :-) David -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH 1/1] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread Joe Perches
On Thu, 2014-02-20 at 21:16 +0800, Fabian Frederick wrote: > afs_vnode is currently cleared with 2 memsets after allocation and > 1 in constructor (afs_i_init_once). Trivial comments: > -This patch calls zalloc for explicit zero fill. OK, but see below. > -Fix some typos. Well...

[PATCH 1/1] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread Fabian Frederick
afs_vnode is currently cleared with 2 memsets after allocation and 1 in constructor (afs_i_init_once). -This patch calls zalloc for explicit zero fill. -Fix some typos. Signed-off-by: Fabian Frederick --- fs/afs/super.c | 12 +--- 1 file changed, 5 insertions(+), 7 delet