Re: [PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-02-21 Thread Jerome Glisse
On Thu, Feb 21, 2019 at 03:59:37PM -0700, Jason Gunthorpe wrote: > On Wed, Feb 20, 2019 at 05:29:24PM -0500, Jerome Glisse wrote: > > > > > > > > Yes it is safe, the hmm struct has its own refcount and mirror holds a > > > > reference on it, the mm struct itself has a reference on the mm > > > > s

Re: [PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-02-21 Thread Jason Gunthorpe
On Wed, Feb 20, 2019 at 05:29:24PM -0500, Jerome Glisse wrote: > > > > > > Yes it is safe, the hmm struct has its own refcount and mirror holds a > > > reference on it, the mm struct itself has a reference on the mm > > > struct. > > > > The issue here is that that hmm_mirror_unregister() must be

Re: [PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-02-20 Thread Jerome Glisse
On Wed, Feb 20, 2019 at 10:20:27PM +, Jason Gunthorpe wrote: > On Tue, Feb 12, 2019 at 11:11:24AM -0500, Jerome Glisse wrote: > > This is what serialize programming the hw and any concurrent CPU page > > table invalidation. This is also one of the thing i want to improve > > long term as mlx5_i

Re: [PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-02-20 Thread Jason Gunthorpe
On Tue, Feb 12, 2019 at 11:11:24AM -0500, Jerome Glisse wrote: > This is what serialize programming the hw and any concurrent CPU page > table invalidation. This is also one of the thing i want to improve > long term as mlx5_ib_update_xlt() can do memory allocation and i would > like to avoid that

Re: [PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-02-12 Thread Haggai Eran
On 2/12/2019 6:11 PM, Jerome Glisse wrote: > On Wed, Feb 06, 2019 at 08:44:26AM +, Haggai Eran wrote: >> On 1/29/2019 6:58 PM, jgli...@redhat.com wrote: >> > Convert ODP to use HMM so that we can build on common infrastructure >> > for different class of devices that want to mirror a proces

Re: [PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-02-12 Thread Jerome Glisse
On Wed, Feb 06, 2019 at 08:44:26AM +, Haggai Eran wrote: > On 1/29/2019 6:58 PM, jgli...@redhat.com wrote: > > Convert ODP to use HMM so that we can build on common infrastructure > > for different class of devices that want to mirror a process address > > space into a device. There is no fu

Re: [PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-02-06 Thread Haggai Eran
On 1/29/2019 6:58 PM, jgli...@redhat.com wrote: > Convert ODP to use HMM so that we can build on common infrastructure > for different class of devices that want to mirror a process address > space into a device. There is no functional changes. Thanks for sending this patch. I think in general

[PATCH 1/1] RDMA/odp: convert to use HMM for ODP

2019-01-29 Thread jglisse
From: Jérôme Glisse Convert ODP to use HMM so that we can build on common infrastructure for different class of devices that want to mirror a process address space into a device. There is no functional changes. Signed-off-by: Jérôme Glisse Cc: linux-r...@vger.kernel.org Cc: Jason Gunthorpe Cc: