Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-14 Thread Tariq Toukan
Thanks Ozgur for your report. On 12/12/2016 8:18 PM, Leon Romanovsky wrote: On Mon, Dec 12, 2016 at 03:04:28PM +0200, Ozgur Karatas wrote: Dear Romanovsky; Please avoid top-posting in your replies. Thanks I'm trying to learn english and I apologize for my mistake words and phrases. So, I th

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Ozgur Karatas
12.12.2016, 20:18, "Leon Romanovsky" : > On Mon, Dec 12, 2016 at 03:04:28PM +0200, Ozgur Karatas wrote: >>  Dear Romanovsky; > > Please avoid top-posting in your replies. > Thanks Dear Leon; thanks for the information., I will pay attention. >>  I'm trying to learn english and I apologize for

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Leon Romanovsky
On Mon, Dec 12, 2016 at 03:04:28PM +0200, Ozgur Karatas wrote: > Dear Romanovsky; Please avoid top-posting in your replies. Thanks > > I'm trying to learn english and I apologize for my mistake words and phrases. > So, I think the code when call to "sg_set_buf" and next time set memory and > bu

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Ozgur Karatas
Dear Romanovsky; I'm trying to learn english and I apologize for my mistake words and phrases. So, I think the code when call to "sg_set_buf" and next time set memory and buffer. For example, isn't to call "WARN_ON" function, get a error to implicit declaration, right? Because, you will use to

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Leon Romanovsky
On Mon, Dec 12, 2016 at 12:58:59PM +0200, Ozgur Karatas wrote: > Hello all, > I think should be use to "WARN_ON" and checkpatch script give to error, I > fixed and I think should don't use "BUG_ON". > Regards, > > Signed-off-by: Ozgur Karatas NAK, Leon Romanovsky If we put aside commit messag

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON

2016-12-12 Thread Ozgur Karatas
Dear Stefan; I'm reading to Documentation/SubmittingPatches and I still apologized for misrepresentations my patches. I will add a next time good commit message and commit subjects. Sorry, Regards Ozgur Karatas 12.12.2016, 13:20, "Stefan Schmidt" : > Hello. > > On 12/12/16 11:58, Ozgur Karat

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Stefan Schmidt
Hello. On 12/12/16 11:58, Ozgur Karatas wrote: Hello all, I think should be use to "WARN_ON" and checkpatch script give to error, I fixed and I think should don't use "BUG_ON". Regards, Signed-off-by: Ozgur Karatas I pointed you already before to the Documentation how to prepare a commit

[PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Ozgur Karatas
Hello all, I think should be use to "WARN_ON" and checkpatch script give to error, I fixed and I think should don't use "BUG_ON". Regards, Signed-off-by: Ozgur Karatas --- drivers/net/ethernet/mellanox/mlx4/icm.c | 4 ++-- diff --git a/drivers/net/ethernet/mellanox/mlx4/icm.c b/drivers/net/e