Re: [PATCH 1/1] Btrfs: Code Cleanup

2016-03-24 Thread David Sterba
On Thu, Mar 24, 2016 at 04:08:18PM +0100, Petr Tesarik wrote: > On Thu, 24 Mar 2016 16:03:07 +0100 > David Sterba wrote: > > > On Sun, Mar 20, 2016 at 03:11:11PM +0800, Flex Liu wrote: > >[...] > > > --- a/fs/btrfs/volumes.c > > > +++ b/fs/btrfs/volumes.c > > > @@ -2325,7 +2325,10 @@ int btrfs_in

Re: [PATCH 1/1] Btrfs: Code Cleanup

2016-03-24 Thread Petr Tesarik
On Thu, 24 Mar 2016 16:03:07 +0100 David Sterba wrote: > On Sun, Mar 20, 2016 at 03:11:11PM +0800, Flex Liu wrote: >[...] > > --- a/fs/btrfs/volumes.c > > +++ b/fs/btrfs/volumes.c > > @@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, > > char *device_path) > > if (see

Re: [PATCH 1/1] Btrfs: Code Cleanup

2016-03-24 Thread David Sterba
On Sun, Mar 20, 2016 at 03:11:11PM +0800, Flex Liu wrote: > From: Flex Liu > > In fs/btrfs/volumes.c:2328 > > if (seeding_dev) { > sb->s_flags &= ~MS_RDONLY; > ret = btrfs_prepare_sprout(root); > BUG_ON(ret); /* -ENOMEM */ > } > >

Re: [PATCH 1/1] Btrfs: Code Cleanup

2016-03-21 Thread Anand Jain
Hi Flex, diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 366b335..5c16f04 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path) if (seeding_dev) { sb->s_flags &=

[PATCH 1/1] Btrfs: Code Cleanup

2016-03-20 Thread Flex Liu
From: Flex Liu In fs/btrfs/volumes.c:2328 if (seeding_dev) { sb->s_flags &= ~MS_RDONLY; ret = btrfs_prepare_sprout(root); BUG_ON(ret); /* -ENOMEM */ } the error code would be return from: fs_devs = kzalloc(sizeof(*fs_devs)