Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-11-13 Thread Tejun Heo
On Thu, Nov 14, 2013 at 08:26:54AM +0800, xiangliang yu wrote: > hi > how about this patch? do you have any update? thanks! Hmm? I already applied the patch manually as I wrote before. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-11-13 Thread xiangliang yu
hi how about this patch? do you have any update? thanks! > On Wed, Oct 16, 2013 at 11:36:20AM2013/10/27 Tejun Heo : > Hello, > +0800, xiangliang yu wrote: >> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c >> index 34c8216..fbe592f 100644 >> --- a/drivers/ata/libahci.c >> +++ b/drivers

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-27 Thread xiangliang yu
Hi, > Your patch is still completely white space corrupted. Please check > your mail settings. Using git-send-email is usually a good idea. I'm > applying the patch manually this time but *please* make sure your mail > setup is working before posting things next time. Sorry, my gmail maybe has

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-27 Thread Tejun Heo
Hello, On Wed, Oct 16, 2013 at 11:36:20AM +0800, xiangliang yu wrote: > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > index 34c8216..fbe592f 100644 > --- a/drivers/ata/libahci.c > +++ b/drivers/ata/libahci.c > @@ -1266,9 +1266,11 @@ int ahci_do_softreset(struct ata_link *link, > uns

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-15 Thread Tejun Heo
Hello, On Tue, Oct 15, 2013 at 11:40:27AM +0800, xiangliang yu wrote: > @@ -1278,6 +1280,11 @@ int ahci_do_softreset(struct ata_link *link, > unsigned int *class, > if (rc && rc != -EOPNOTSUPP) > ata_link_warn(link, "failed to reset engine (errno=%d)\n", rc); > Please add a comment here. >

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-14 Thread xiangliang yu
Can you please update the patch > description so that it includes what was failing before and how it was > tested? How about this update: Subject: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset Tested with Marvell 88se9125, attached with one port mulitplier(5 ports) and one

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-13 Thread xiangliang yu
Hi, > On Sat, Oct 12, 2013 at 02:56:34PM +0800, xiangliang yu wrote: >> > So it can't find the disk if FBS stays enabled? Can you please attach >> > the boot log before & after? >> >> Below is boot log: > > And it works after the patch, right? Can you please update the patch > description so tha

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-13 Thread Tejun Heo
Hello, On Sat, Oct 12, 2013 at 02:56:34PM +0800, xiangliang yu wrote: > > So it can't find the disk if FBS stays enabled? Can you please attach > > the boot log before & after? > > Below is boot log: And it works after the patch, right? Can you please update the patch description so that it in

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-11 Thread xiangliang yu
Hi, > On Sat, Sep 28, 2013 at 09:04:15PM +0800, xiangliang yu wrote: >> hi, Tejun >> i had tested the patch with Marvell 88se9235. And driver can find disk >> if FBS disabled, or can't find disk. > > So it can't find the disk if FBS stays enabled? Can you please attach > the boot log before & af

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread Sergei Shtylyov
Hello. On 28-09-2013 15:13, Xiangliang Yu wrote: If device is attached to port multiplier, the detection process look like this: ahci_hardreset(link, class, deadline) if (class == ATA_DEV_PMP) { sata_pmp_attach(dev)/* will enable FBS */ sata_p

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread Tejun Heo
Hello, On Sat, Sep 28, 2013 at 09:04:15PM +0800, xiangliang yu wrote: > hi, Tejun > i had tested the patch with Marvell 88se9235. And driver can find disk > if FBS disabled, or can't find disk. So it can't find the disk if FBS stays enabled? Can you please attach the boot log before & after? >

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread xiangliang yu
hi, Tejun i had tested the patch with Marvell 88se9235. And driver can find disk if FBS disabled, or can't find disk. Please see chapter 9.3.9 and 9.3.8 of AHCI spec. Thanks. 2013/9/28 Tejun Heo : > Hello, > > On Sat, Sep 28, 2013 at 07:13:36PM +0800, Xiangliang Yu wrote: >> If device is attached

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread Tejun Heo
Hello, On Sat, Sep 28, 2013 at 07:13:36PM +0800, Xiangliang Yu wrote: > If device is attached to port multiplier, the detection process > look like this: > ahci_hardreset(link, class, deadline) > if (class == ATA_DEV_PMP) { > sata_pmp_attach(dev)/* will enable FBS */

[PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread Xiangliang Yu
If device is attached to port multiplier, the detection process look like this: ahci_hardreset(link, class, deadline) if (class == ATA_DEV_PMP) { sata_pmp_attach(dev)/* will enable FBS */ sata_pmp_init_links(ap, nr_ports); ata_for_