Re: [PATCH 09/39] Annotate hardware config module parameters in drivers/i2c/

2016-12-05 Thread One Thousand Gnomes
O> > > Suggested-by: One Thousand Gnomes > > > > I know this is only a Suggested-by and not a Signed-off-by, but still I > > believe the Developer's Certificate of Origin applies, and it says: > > "using your real name (sorry, no pseudonyms or anonymous > > contributions.)" > > I asked him w

Re: [PATCH 09/39] Annotate hardware config module parameters in drivers/i2c/

2016-12-01 Thread Jean Delvare
On jeu., 2016-12-01 at 14:12 +, David Howells wrote: > Jean Delvare wrote: > > > > Note that we do still need to do the module initialisation because some > > > drivers have viable defaults set in case parameters aren't specified and > > > some drivers support automatic configuration (e.g. PN

Re: [PATCH 09/39] Annotate hardware config module parameters in drivers/i2c/

2016-12-01 Thread David Howells
Jean Delvare wrote: > > Note that we do still need to do the module initialisation because some > > drivers have viable defaults set in case parameters aren't specified and > > some drivers support automatic configuration (e.g. PNP or PCI) in addition > > to manually coded parameters. > > Initia

Re: [PATCH 09/39] Annotate hardware config module parameters in drivers/i2c/

2016-12-01 Thread Jean Delvare
Hi David, On jeu., 2016-12-01 at 12:30 +, David Howells wrote: > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > ac

[PATCH 09/39] Annotate hardware config module parameters in drivers/i2c/

2016-12-01 Thread David Howells
When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a devi