Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

2013-10-21 Thread Adrian Hunter
On 21/10/2013 5:12 p.m., Arnaldo Carvalho de Melo wrote: Em Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter escreveu: Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS was not passed around. Unfortunately passing CFLAGS seems to break some of the tests, so this needs more work.

Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

2013-10-21 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter escreveu: > Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS > was not passed around. > index c873e03..699cdb7 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -706,7 +706,7 @@ $(LIB_FILE): $(LIB_OBJS) >

Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

2013-10-21 Thread Adrian Hunter
On 21/10/13 11:46, Jiri Olsa wrote: > On Mon, Oct 21, 2013 at 08:53:04AM +0300, Adrian Hunter wrote: >> On 20/10/13 23:42, Jiri Olsa wrote: >>> On Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter wrote: Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS was not passed around. >>> >

Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

2013-10-21 Thread Jiri Olsa
On Mon, Oct 21, 2013 at 08:53:04AM +0300, Adrian Hunter wrote: > On 20/10/13 23:42, Jiri Olsa wrote: > > On Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter wrote: > >> Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS > >> was not passed around. > > > > this breaks feature detection for m

Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

2013-10-20 Thread Adrian Hunter
On 20/10/13 23:42, Jiri Olsa wrote: > On Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter wrote: >> Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS >> was not passed around. > > this breaks feature detection for me on x86_64, > I've got following errors misdetection with this patch: > >

Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

2013-10-20 Thread Jiri Olsa
On Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter wrote: > Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS > was not passed around. this breaks feature detection for me on x86_64, I've got following errors misdetection with this patch: ... libperl: [ OFF ] ...

[PATCH 09/19] perf tools: Fix 32-bit cross build

2013-10-18 Thread Adrian Hunter
Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS was not passed around. Signed-off-by: Adrian Hunter --- tools/perf/Makefile.perf | 2 +- tools/perf/config/Makefile| 4 ++-- tools/perf/config/feature-checks/Makefile | 2 +- 3 files changed, 4 insertions(+),