Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-20 Thread Henrik Rydberg
> > Collect common frame synchronization tasks in a new function, > > input_mt_sync_frame(). Depending on the flags set, it drops > > unseen contacts and performs pointer emulation. > > I was really wondering why you needed to put in input-mt something > that appeared only in hid-multitouch un

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-20 Thread Benjamin Tissoires
Hi Henrik, thanks for this patch set. I'm also happy when someone tries to factorize and optimize some code. I have a few concerns though: On Sun, Aug 12, 2012 at 11:42 PM, Henrik Rydberg wrote: > Collect common frame synchronization tasks in a new function, > input_mt_sync_frame(). Depending on

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-16 Thread Henrik Rydberg
> For example, the new input_mt_init_slots() takes care of the > __set_bit() functions in one place. That is great. But, it requires > wacom_wac.c to be updated since it has an interface change. I guess > there are other drivers calling input_mt_init_slots as well. The default behavior in the "new

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-16 Thread Ping Cheng
On Thu, Aug 16, 2012 at 11:07 AM, Henrik Rydberg wrote: > On Wed, Aug 15, 2012 at 04:28:17PM -0700, Ping Cheng wrote: >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: >> > Collect common frame synchronization tasks in a new function, >> > input_mt_sync_frame(). Depending on the flags set

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-16 Thread Ping Cheng
On Thu, Aug 16, 2012 at 11:07 AM, Henrik Rydberg wrote: > On Wed, Aug 15, 2012 at 04:28:17PM -0700, Ping Cheng wrote: >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: >> > Collect common frame synchronization tasks in a new function, >> > input_mt_sync_frame(). Depending on the flags set

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-16 Thread Henrik Rydberg
On Wed, Aug 15, 2012 at 04:28:17PM -0700, Ping Cheng wrote: > On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: > > Collect common frame synchronization tasks in a new function, > > input_mt_sync_frame(). Depending on the flags set, it drops > > unseen contacts and performs pointer emulation.

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-15 Thread Ping Cheng
On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: > Collect common frame synchronization tasks in a new function, > input_mt_sync_frame(). Depending on the flags set, it drops > unseen contacts and performs pointer emulation. > > Signed-off-by: Henrik Rydberg I went through the patchset exc

[PATCH 09/19] Input: MT - Handle frame synchronization in core

2012-08-12 Thread Henrik Rydberg
Collect common frame synchronization tasks in a new function, input_mt_sync_frame(). Depending on the flags set, it drops unseen contacts and performs pointer emulation. Signed-off-by: Henrik Rydberg --- drivers/input/input-mt.c | 74 ++-- include/linu