Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-08-11 Thread Anatoly Pugachev
On Sat, Aug 10, 2019 at 10:36 PM Mikael Pettersson wrote: > For the record the futex test case OOPSes a 5.3-rc3 kernel running on > a Sun Blade 2500 (2 x USIIIi). This system runs a custom distro with > a custom toolchain (gcc-8.3 based), so I doubt it's a distro problem. Mikael, Khalid, can yo

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-08-10 Thread Mikael Pettersson
For the record the futex test case OOPSes a 5.3-rc3 kernel running on a Sun Blade 2500 (2 x USIIIi). This system runs a custom distro with a custom toolchain (gcc-8.3 based), so I doubt it's a distro problem. On Sat, Aug 10, 2019 at 9:17 AM Christoph Hellwig wrote: > > There isn't really a way t

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-08-10 Thread Christoph Hellwig
There isn't really a way to use an arch-specific get_user_pages_fast in mainline, you'd need to revert the whole series. As a relatively quick workaround you can just remove the select HAVE_FAST_GUP if SPARC64 line from arch/sparc/Kconfig

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-08-09 Thread Anatoly Pugachev
On Thu, Jul 18, 2019 at 12:59 AM Dmitry V. Levin wrote: > On Tue, Jun 25, 2019 at 04:37:08PM +0200, Christoph Hellwig wrote: > > The sparc64 code is mostly equivalent to the generic one, minus various > > bugfixes and two arch overrides that this patch adds to pgtable.h. > > > > Signed-off-by: Chr

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-28 Thread Anatoly Pugachev
On Sun, Jul 28, 2019 at 5:09 AM David Miller wrote: > From: Anatoly Pugachev > Date: Thu, 25 Jul 2019 21:33:24 +0300 > > there's vmlinuz-5.3.0-rc1 kernel and archive 5.3.0-rc1-modules.tar.gz > > of /lib/modules/5.3.0-rc1/ > > this is from oracle sparclinux LDOM , compiled with 7.4.0 gcc > > Pleas

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-27 Thread David Miller
From: Anatoly Pugachev Date: Thu, 25 Jul 2019 21:33:24 +0300 > http://u164.east.ru/kernel/ > > there's vmlinuz-5.3.0-rc1 kernel and archive 5.3.0-rc1-modules.tar.gz > of /lib/modules/5.3.0-rc1/ > this is from oracle sparclinux LDOM , compiled with 7.4.0 gcc Please, I really really need the unst

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-26 Thread Khalid Aziz
On 7/17/19 3:59 PM, Dmitry V. Levin wrote: > Hi, > > On Tue, Jun 25, 2019 at 04:37:08PM +0200, Christoph Hellwig wrote: >> The sparc64 code is mostly equivalent to the generic one, minus various >> bugfixes and two arch overrides that this patch adds to pgtable.h. >> >> Signed-off-by: Christoph He

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-25 Thread David Miller
From: Anatoly Pugachev Date: Thu, 25 Jul 2019 21:33:24 +0300 > http://u164.east.ru/kernel/ > > there's vmlinuz-5.3.0-rc1 kernel and archive 5.3.0-rc1-modules.tar.gz > of /lib/modules/5.3.0-rc1/ > this is from oracle sparclinux LDOM , compiled with 7.4.0 gcc Thank you, I'll take a look.

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-25 Thread Anatoly Pugachev
On Wed, Jul 24, 2019 at 11:13 PM David Miller wrote: > > From: Anatoly Pugachev > Date: Wed, 24 Jul 2019 22:32:17 +0300 > > > the first test where it was discovered was done on my test LDOM named > > ttip, hardware (hypervisor) is T5-2 server, running under Solaris 11.4 > > OS. > > ttip LDOM is d

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-24 Thread David Miller
From: Anatoly Pugachev Date: Wed, 24 Jul 2019 22:32:17 +0300 > the first test where it was discovered was done on my test LDOM named > ttip, hardware (hypervisor) is T5-2 server, running under Solaris 11.4 > OS. > ttip LDOM is debian sparc64 unstable , so with almost all the latest > software (gc

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-24 Thread Anatoly Pugachev
On Fri, Jul 19, 2019 at 12:14 AM David Miller wrote: > > So this ended up as commit 7b9afb86b6328f10dc2cad9223d7def12d60e505 > > (thanks to Anatoly for bisecting) and introduced a regression: > > futex.test from the strace test suite now causes an Oops on sparc64 > > in futex syscall. > > > > Here

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-18 Thread Christoph Hellwig
On Thu, Jul 18, 2019 at 02:14:05PM -0700, David Miller wrote: > From: "Dmitry V. Levin" > Date: Thu, 18 Jul 2019 00:59:56 +0300 > > > So this ended up as commit 7b9afb86b6328f10dc2cad9223d7def12d60e505 > > (thanks to Anatoly for bisecting) and introduced a regression: > > futex.test from the str

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-18 Thread David Miller
From: Linus Torvalds Date: Wed, 17 Jul 2019 17:17:16 -0700 > From the oops, I assume that the problem is that get_user_pages_fast() > returned an invalid page, causing the bad access later in > get_futex_key(). That's correct. It's the first deref of page that oops's. > But that's odd too, co

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-18 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 18 Jul 2019 00:59:56 +0300 > So this ended up as commit 7b9afb86b6328f10dc2cad9223d7def12d60e505 > (thanks to Anatoly for bisecting) and introduced a regression: > futex.test from the strace test suite now causes an Oops on sparc64 > in futex syscall. > > Here

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-17 Thread David Miller
From: Linus Torvalds Date: Wed, 17 Jul 2019 17:17:16 -0700 > Anyway, I suspect some sparc64 person needs to delve into it. I'll take a look at it soon if someone doesn't figure it out before me.

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-17 Thread Linus Torvalds
On Wed, Jul 17, 2019 at 4:30 PM Dmitry V. Levin wrote: > > Sure, here it is: Hmm. I'm not seeing anything obviously wrong in the generic gup conversion. >From the oops, I assume that the problem is that get_user_pages_fast() returned an invalid page, causing the bad access later in get_futex_key

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-17 Thread Dmitry V. Levin
On Wed, Jul 17, 2019 at 03:04:56PM -0700, Linus Torvalds wrote: > On Wed, Jul 17, 2019 at 2:59 PM Dmitry V. Levin wrote: > > > > So this ended up as commit 7b9afb86b6328f10dc2cad9223d7def12d60e505 > > (thanks to Anatoly for bisecting) and introduced a regression: > > futex.test from the strace tes

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-17 Thread Linus Torvalds
On Wed, Jul 17, 2019 at 2:59 PM Dmitry V. Levin wrote: > > So this ended up as commit 7b9afb86b6328f10dc2cad9223d7def12d60e505 > (thanks to Anatoly for bisecting) and introduced a regression: > futex.test from the strace test suite now causes an Oops on sparc64 > in futex syscall. Can you post th

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-07-17 Thread Dmitry V. Levin
Hi, On Tue, Jun 25, 2019 at 04:37:08PM +0200, Christoph Hellwig wrote: > The sparc64 code is mostly equivalent to the generic one, minus various > bugfixes and two arch overrides that this patch adds to pgtable.h. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Khalid Aziz > --- > arch/spa

[PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-06-25 Thread Christoph Hellwig
The sparc64 code is mostly equivalent to the generic one, minus various bugfixes and two arch overrides that this patch adds to pgtable.h. Signed-off-by: Christoph Hellwig Reviewed-by: Khalid Aziz --- arch/sparc/Kconfig | 1 + arch/sparc/include/asm/pgtable_64.h | 18 ++ arc

Re: [PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-06-11 Thread Khalid Aziz
On 6/11/19 8:40 AM, Christoph Hellwig wrote: > The sparc64 code is mostly equivalent to the generic one, minus various > bugfixes and two arch overrides that this patch adds to pgtable.h. > > Signed-off-by: Christoph Hellwig > --- > arch/sparc/Kconfig | 1 + > arch/sparc/inclu

[PATCH 09/16] sparc64: use the generic get_user_pages_fast code

2019-06-11 Thread Christoph Hellwig
The sparc64 code is mostly equivalent to the generic one, minus various bugfixes and two arch overrides that this patch adds to pgtable.h. Signed-off-by: Christoph Hellwig --- arch/sparc/Kconfig | 1 + arch/sparc/include/asm/pgtable_64.h | 18 ++ arch/sparc/mm/Makefile