Re: [PATCH 09/14] tty/serial/amba-pl011: Implement clear_irqs callback

2012-09-10 Thread Anton Vorontsov
On Mon, Sep 10, 2012 at 12:17:02PM +0100, Alan Cox wrote: [...] > > +static void pl011_clear_irqs(struct uart_port *port) > > +{ > > + struct uart_amba_port *uap = (struct uart_amba_port *)port; > > + unsigned char __iomem *regs = uap->port.membase; > > + > > + writew(readw(regs + UART011_MIS

Re: [PATCH 09/14] tty/serial/amba-pl011: Implement clear_irqs callback

2012-09-10 Thread Alan Cox
On Sun, 9 Sep 2012 21:14:04 -0700 Anton Vorontsov wrote: > It's all pretty straightforward, except for TXIM interrupt. The interrupt > has meaning "ready to transmit", so it's almost always raised, and the > only way to silence it is to mask it. But that's OK, ops->start_tx will > unmask it. > >

[PATCH 09/14] tty/serial/amba-pl011: Implement clear_irqs callback

2012-09-09 Thread Anton Vorontsov
It's all pretty straightforward, except for TXIM interrupt. The interrupt has meaning "ready to transmit", so it's almost always raised, and the only way to silence it is to mask it. But that's OK, ops->start_tx will unmask it. Signed-off-by: Anton Vorontsov --- drivers/tty/serial/amba-pl011.c |