Re: [PATCH 09/14] net: sched: don't release reference on action overwrite

2018-05-20 Thread Vlad Buslov
On Sat 19 May 2018 at 21:52, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:10PM +0300, Vlad Buslov wrote: >> Return from action init function with reference to action taken, >> even when overwriting existing action. > > Isn't this patch necessary before patch 7, to not break thin

Re: [PATCH 09/14] net: sched: don't release reference on action overwrite

2018-05-19 Thread Marcelo Ricardo Leitner
On Mon, May 14, 2018 at 05:27:10PM +0300, Vlad Buslov wrote: > Return from action init function with reference to action taken, > even when overwriting existing action. Isn't this patch necessary before patch 7, to not break things up? AFAICU after patchset 7 it assumes the action init function is

Re: [PATCH 09/14] net: sched: don't release reference on action overwrite

2018-05-16 Thread Jiri Pirko
Wed, May 16, 2018 at 09:47:32AM CEST, vla...@mellanox.com wrote: > >On Wed 16 May 2018 at 07:43, Jiri Pirko wrote: >> Mon, May 14, 2018 at 04:27:10PM CEST, vla...@mellanox.com wrote: >>>Return from action init function with reference to action taken, >>>even when overwriting existing action. >>> >

Re: [PATCH 09/14] net: sched: don't release reference on action overwrite

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 07:43, Jiri Pirko wrote: > Mon, May 14, 2018 at 04:27:10PM CEST, vla...@mellanox.com wrote: >>Return from action init function with reference to action taken, >>even when overwriting existing action. >> >>Action init API initializes its fourth argument (pointer to pointer to

Re: [PATCH 09/14] net: sched: don't release reference on action overwrite

2018-05-16 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:10PM CEST, vla...@mellanox.com wrote: >Return from action init function with reference to action taken, >even when overwriting existing action. > >Action init API initializes its fourth argument (pointer to pointer to >tc action) to either existing action with same index

[PATCH 09/14] net: sched: don't release reference on action overwrite

2018-05-14 Thread Vlad Buslov
Return from action init function with reference to action taken, even when overwriting existing action. Action init API initializes its fourth argument (pointer to pointer to tc action) to either existing action with same index or newly created action. In case of existing index(and bind argument i