Re: [PATCH 09/12] xfs: refactor the ioend merging code

2019-06-25 Thread Darrick J. Wong
On Tue, Jun 25, 2019 at 03:42:20PM +0300, Nikolay Borisov wrote: > > > On 25.06.19 г. 13:14 ч., Christoph Hellwig wrote: > > On Mon, Jun 24, 2019 at 07:06:22PM +0300, Nikolay Borisov wrote: > >>> +{ > >>> + struct list_headtmp; > >>> + > >>> + list_replace_init(&ioend->io_list, &tmp); > >

Re: [PATCH 09/12] xfs: refactor the ioend merging code

2019-06-25 Thread Nikolay Borisov
On 25.06.19 г. 13:14 ч., Christoph Hellwig wrote: > On Mon, Jun 24, 2019 at 07:06:22PM +0300, Nikolay Borisov wrote: >>> +{ >>> + struct list_headtmp; >>> + >>> + list_replace_init(&ioend->io_list, &tmp); >>> + xfs_destroy_ioend(ioend, error); >>> + while ((ioend = list_pop(&tmp,

Re: [PATCH 09/12] xfs: refactor the ioend merging code

2019-06-25 Thread Christoph Hellwig
On Mon, Jun 24, 2019 at 07:06:22PM +0300, Nikolay Borisov wrote: > > +{ > > + struct list_headtmp; > > + > > + list_replace_init(&ioend->io_list, &tmp); > > + xfs_destroy_ioend(ioend, error); > > + while ((ioend = list_pop(&tmp, struct xfs_ioend, io_list))) > > + xfs_destr

Re: [PATCH 09/12] xfs: refactor the ioend merging code

2019-06-24 Thread Nikolay Borisov
On 24.06.19 г. 8:52 ч., Christoph Hellwig wrote: > Introduce two nicely abstracted helper, which can be moved to the > iomap code later. Also use list_pop and list_first_entry_or_null > to simplify the code a bit. > > Signed-off-by: Christoph Hellwig > --- > fs/xfs/xfs_aops.c | 66 ++

Re: [PATCH 09/12] xfs: refactor the ioend merging code

2019-06-24 Thread Darrick J. Wong
On Mon, Jun 24, 2019 at 07:52:50AM +0200, Christoph Hellwig wrote: > Introduce two nicely abstracted helper, which can be moved to the > iomap code later. Also use list_pop and list_first_entry_or_null > to simplify the code a bit. > > Signed-off-by: Christoph Hellwig Looks ok, Reviewed-by: Dar

[PATCH 09/12] xfs: refactor the ioend merging code

2019-06-23 Thread Christoph Hellwig
Introduce two nicely abstracted helper, which can be moved to the iomap code later. Also use list_pop and list_first_entry_or_null to simplify the code a bit. Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_aops.c | 66 ++- 1 file changed, 36 insertio