Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo

2016-06-06 Thread John Crispin
On 06/06/2016 14:21, Andrew Lunn wrote: >> Hi Andrew, >> >> it is waiting for the watchdog to trigger :-) TBH the 1s seems to be too >> short to for the dma ring length to be flushed and i had to pick some >> value and 5 is used most places. >> >> it really depends on the amount of packets in the

Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo

2016-06-06 Thread Andrew Lunn
> Hi Andrew, > > it is waiting for the watchdog to trigger :-) TBH the 1s seems to be too > short to for the dma ring length to be flushed and i had to pick some > value and 5 is used most places. > > it really depends on the amount of packets in the queue, their length > and the mac setting. the

Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo

2016-06-05 Thread John Crispin
On 05/06/2016 16:56, Andrew Lunn wrote: > On Sun, Jun 05, 2016 at 08:33:02AM +0200, John Crispin wrote: >> During stress testing, after reducing the threshold value, we have seen >> TX timeouts that were caused by the watchdog_timeo value being too low. >> Increase the value to 5 * HZ which is a

Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo

2016-06-05 Thread Andrew Lunn
On Sun, Jun 05, 2016 at 08:33:02AM +0200, John Crispin wrote: > During stress testing, after reducing the threshold value, we have seen > TX timeouts that were caused by the watchdog_timeo value being too low. > Increase the value to 5 * HZ which is a value commonly used by many other > drivers. I

[PATCH 09/12] net: mediatek: increase watchdog_timeo

2016-06-04 Thread John Crispin
During stress testing, after reducing the threshold value, we have seen TX timeouts that were caused by the watchdog_timeo value being too low. Increase the value to 5 * HZ which is a value commonly used by many other drivers. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth