Re: [PATCH 09/11] drivers/scsi: include for modular ufshcd-pltfrm code

2015-05-01 Thread James Bottomley
On Fri, 2015-05-01 at 09:37 -0400, Paul Gortmaker wrote: > On 15-04-30 10:35 PM, James Bottomley wrote: > > On Thu, 2015-04-30 at 21:47 -0400, Paul Gortmaker wrote: > >> This file is built off of a tristate Kconfig option and also contains > >> modular function calls so it should explicitly include

Re: [PATCH 09/11] drivers/scsi: include for modular ufshcd-pltfrm code

2015-05-01 Thread Paul Gortmaker
On 15-04-30 10:35 PM, James Bottomley wrote: > On Thu, 2015-04-30 at 21:47 -0400, Paul Gortmaker wrote: >> This file is built off of a tristate Kconfig option and also contains >> modular function calls so it should explicitly include module.h to >> avoid compile breakage during header shuffles don

Re: [PATCH 09/11] drivers/scsi: include for modular ufshcd-pltfrm code

2015-04-30 Thread James Bottomley
On Thu, 2015-04-30 at 21:47 -0400, Paul Gortmaker wrote: > This file is built off of a tristate Kconfig option and also contains > modular function calls so it should explicitly include module.h to > avoid compile breakage during header shuffles done in the future. I don't understand your logic.

[PATCH 09/11] drivers/scsi: include for modular ufshcd-pltfrm code

2015-04-30 Thread Paul Gortmaker
This file is built off of a tristate Kconfig option and also contains modular function calls so it should explicitly include module.h to avoid compile breakage during header shuffles done in the future. Cc: Vinayak Holikatti Cc: "James E.J. Bottomley" Cc: linux-s...@vger.kernel.org Signed-off-by