Re: Another version of cleanfile/cleanpatch (Re: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines)

2007-06-06 Thread Sam Ravnborg
On Wed, Jun 06, 2007 at 07:45:56PM +0200, Oleg Verych wrote: > While i'm against whitespace damaged files or patches since my very > first patch, and don't like brain damaged programmer's tools called > text editors, i also want to encourage UNIX-way of using userspace. > > Of course, i might be w

Another version of cleanfile/cleanpatch (Re: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines)

2007-06-06 Thread Oleg Verych
While i'm against whitespace damaged files or patches since my very first patch, and don't like brain damaged programmer's tools called text editors, i also want to encourage UNIX-way of using userspace. Of course, i might be wrong and foolish. Anyway, what i'm trying to do is not to become new ge

Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-05 Thread Oleg Verych
On Tue, Jun 05, 2007 at 04:57:59PM +0200, Oleg Verych wrote: [] > expand | while read line > do case "$line" in >++*) echo "$line";; >$p*) [ ${#line} -gt $w79 ] && : ${long:=line} > echo "$line" | sed "/^$p/{s_ *\$__;s_^$p$s7${s}_$p${t}_;s_$s7 _${t}_g}" > ;; > *) echo

Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-05 Thread Oleg Verych
On Tue, Jun 05, 2007 at 04:12:54PM +0200, Sam Ravnborg wrote: > On Tue, Jun 05, 2007 at 03:38:34PM +0200, Oleg Verych wrote: > > On Tue, Jun 05, 2007 at 10:19:59AM +0200, Sam Ravnborg wrote: > > [] > > > If on the other hand you are proposing a script to clean whitespace > > > damage in the code th

Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-05 Thread Sam Ravnborg
On Tue, Jun 05, 2007 at 03:38:34PM +0200, Oleg Verych wrote: > On Tue, Jun 05, 2007 at 10:19:59AM +0200, Sam Ravnborg wrote: > [] > > If on the other hand you are proposing a script to clean whitespace > > damage in the code then git already does this nicely. > > I've read that too quickly, sorry.

Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-05 Thread Oleg Verych
On Tue, Jun 05, 2007 at 10:19:59AM +0200, Sam Ravnborg wrote: [] > If on the other hand you are proposing a script to clean whitespace > damage in the code then git already does this nicely. I've read that too quickly, sorry. What then all that clean scripts are for? > I do not recall the actual

Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-05 Thread Oleg Verych
On Tue, Jun 05, 2007 at 10:19:59AM +0200, Sam Ravnborg wrote: [] > > So, there are some new scripts. What if my proposition will be better, > > so to speak? Any problems i'm willing to fix/enhance. > > > > Note: only one copy of the file required. Sym-linked name *diff* or > > *patch* will process

Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-05 Thread Sam Ravnborg
On Tue, Jun 05, 2007 at 09:33:35AM +0200, Oleg Verych wrote: > Hallo. > > On Sun, Jun 03, 2007 at 10:47:00PM +0200, Sam Ravnborg wrote: > > Subject: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long > > lines > > From: H. Peter Anvin <[EMAIL PROTECTE

Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-05 Thread Oleg Verych
Hallo. On Sun, Jun 03, 2007 at 10:47:00PM +0200, Sam Ravnborg wrote: > Subject: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long > lines > From: H. Peter Anvin <[EMAIL PROTECTED]> > Date: Fri, 25 May 2007 17:58:26 -0700 > > Make the "cleanfile"

Re: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-04 Thread Jan Engelhardt
On Jun 3 2007 22:47, Sam Ravnborg wrote: > >Make the "cleanfile" and "cleanpatch" script warn about long lines, >by default lines whose visual width exceeds 79 characters. Nice, nice. But, am I asking too much if tabs and kernel codestyle could be used? (/me hides..., but see scripts/checkpatch.p

[PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines

2007-06-03 Thread Sam Ravnborg
Subject: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines From: H. Peter Anvin <[EMAIL PROTECTED]> Date: Fri, 25 May 2007 17:58:26 -0700 Make the "cleanfile" and "cleanpatch" script warn about long lines, by default lines whose visual width e