Re: [PATCH 08/17] x86/ftrace: set trampoline pages as executable

2019-02-06 Thread Steven Rostedt
On Wed, 6 Feb 2019 09:33:35 -0800 Nadav Amit wrote: > >>/* Copy ftrace_caller onto the trampoline memory */ > >>ret = probe_kernel_read(trampoline, (void *)start_offset, size); > >> @@ -818,6 +820,13 @@ create_trampoline(struct ftrace_ops *ops, unsigned > >> int *tramp_size) > >>/*

Re: [PATCH 08/17] x86/ftrace: set trampoline pages as executable

2019-02-06 Thread Nadav Amit
> On Feb 6, 2019, at 8:22 AM, Steven Rostedt wrote: > > On Wed, 16 Jan 2019 16:32:50 -0800 > Rick Edgecombe wrote: > >> From: Nadav Amit >> >> Since alloc_module() will not set the pages as executable soon, we need >> to do so for ftrace trampoline pages after they are allocated. >> >> For t

Re: [PATCH 08/17] x86/ftrace: set trampoline pages as executable

2019-02-06 Thread Steven Rostedt
On Wed, 16 Jan 2019 16:32:50 -0800 Rick Edgecombe wrote: > From: Nadav Amit > > Since alloc_module() will not set the pages as executable soon, we need > to do so for ftrace trampoline pages after they are allocated. > > For the time being, we do not change ftrace to use the text_poke() > inte

[PATCH 08/17] x86/ftrace: set trampoline pages as executable

2019-01-16 Thread Rick Edgecombe
From: Nadav Amit Since alloc_module() will not set the pages as executable soon, we need to do so for ftrace trampoline pages after they are allocated. For the time being, we do not change ftrace to use the text_poke() interface. As a result, ftrace breaks still breaks W^X. Cc: Steven Rostedt