Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-07-10 Thread Kees Cook
On Wed, Jul 10, 2019 at 06:09:31PM -0400, J. Bruce Fields wrote: > On Fri, Jun 28, 2019 at 12:33:58PM -0400, J. Bruce Fields wrote: > > But I may just give up and go with my existing patch and put > > off that project indefinitely, especially if there's no real need to fix > > the existing callers.

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-07-10 Thread J. Bruce Fields
On Fri, Jun 28, 2019 at 12:33:58PM -0400, J. Bruce Fields wrote: > But I may just give up and go with my existing patch and put > off that project indefinitely, especially if there's no real need to fix > the existing callers. I went with the existing patch, but gave a little more thought to strin

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-28 Thread J. Bruce Fields
On Thu, Jun 27, 2019 at 08:58:22PM -0700, Kees Cook wrote: > On Thu, Jun 27, 2019 at 04:21:24PM -0400, J. Bruce Fields wrote: > > No, I was confused: "\n" is non-printable according to isprint(), so > > ESCAPE_ANY_NP *will* escape it. So this isn't quite so bad. SSIDs are > > usually printed as '

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-27 Thread Kees Cook
On Thu, Jun 27, 2019 at 04:21:24PM -0400, J. Bruce Fields wrote: > No, I was confused: "\n" is non-printable according to isprint(), so > ESCAPE_ANY_NP *will* escape it. So this isn't quite so bad. SSIDs are > usually printed as '%*pE', so arguably we should be escaping the single > quote charact

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-27 Thread J. Bruce Fields
On Wed, Jun 26, 2019 at 12:21:49PM -0400, J. Bruce Fields wrote: > On Mon, Jun 24, 2019 at 05:05:12PM -0400, J. Bruce Fields wrote: > > On Sat, Jun 22, 2019 at 01:22:56PM -0700, Kees Cook wrote: > > > On Sat, Jun 22, 2019 at 03:00:58PM -0400, J. Bruce Fields wrote: > > > > The logic around ESCAPE_N

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-27 Thread J. Bruce Fields
On Wed, Jun 26, 2019 at 09:16:44PM -0700, Kees Cook wrote: > Right -- any they're almost all logged surrounded by ' or " which means > those would need to be escaped as well. The prism2 is leaking newlines > too, as well as the thunderbolt sysfs printing. > > So... seems like we should fix this. :

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-26 Thread Kees Cook
On Wed, Jun 26, 2019 at 12:21:49PM -0400, J. Bruce Fields wrote: > On Mon, Jun 24, 2019 at 05:05:12PM -0400, J. Bruce Fields wrote: > > On Sat, Jun 22, 2019 at 01:22:56PM -0700, Kees Cook wrote: > > > On Sat, Jun 22, 2019 at 03:00:58PM -0400, J. Bruce Fields wrote: > > > > The logic around ESCAPE_N

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-26 Thread J. Bruce Fields
On Mon, Jun 24, 2019 at 05:05:12PM -0400, J. Bruce Fields wrote: > On Sat, Jun 22, 2019 at 01:22:56PM -0700, Kees Cook wrote: > > On Sat, Jun 22, 2019 at 03:00:58PM -0400, J. Bruce Fields wrote: > > > The logic around ESCAPE_NP and the "only" string is really confusing. I > > > started assuming I

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-24 Thread J. Bruce Fields
On Sat, Jun 22, 2019 at 01:22:56PM -0700, Kees Cook wrote: > On Sat, Jun 22, 2019 at 03:00:58PM -0400, J. Bruce Fields wrote: > > The logic around ESCAPE_NP and the "only" string is really confusing. I > > started assuming I could just add an ESCAPE_NONASCII flag and stick " > > and \ into the "on

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-22 Thread Kees Cook
On Sat, Jun 22, 2019 at 03:00:58PM -0400, J. Bruce Fields wrote: > The logic around ESCAPE_NP and the "only" string is really confusing. I > started assuming I could just add an ESCAPE_NONASCII flag and stick " > and \ into the "only" string, but it doesn't work that way. Yeah, if ESCAPE_NP isn't

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-22 Thread J. Bruce Fields
On Fri, Jun 21, 2019 at 03:26:00PM -0700, Kees Cook wrote: > On Fri, Jun 21, 2019 at 01:45:44PM -0400, J. Bruce Fields wrote: > > I'm not sure who to get review from for this kind of thing. > > > > Kees, you seem to be one of the only people to touch string_helpers.c > > at all recently, any ideas

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-21 Thread Kees Cook
On Fri, Jun 21, 2019 at 01:45:44PM -0400, J. Bruce Fields wrote: > I'm not sure who to get review from for this kind of thing. > > Kees, you seem to be one of the only people to touch string_helpers.c > at all recently, any ideas? Hi! Yeah, I'm happy to take a look. Notes below... > > --b. > >

Re: [PATCH 08/16] nfsd: escape high characters in binary data

2019-06-21 Thread J. Bruce Fields
I'm not sure who to get review from for this kind of thing. Kees, you seem to be one of the only people to touch string_helpers.c at all recently, any ideas? --b. On Thu, Jun 20, 2019 at 10:51:07AM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > I'm exposing some information about